Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure EXTRA_OPTS is checked before adding it to entrypoint #289

Open
dsimog01 opened this issue Mar 15, 2023 · 1 comment
Open

Ensure EXTRA_OPTS is checked before adding it to entrypoint #289

dsimog01 opened this issue Mar 15, 2023 · 1 comment
Labels
enhancement New feature or request P1 Has to be done but not urgent

Comments

@dsimog01
Copy link
Contributor

This issue is tightly related to dappnode/DAppNode#549

During the building process of each package. the SDK should perform the following tasks for each service that includes the EXTRA_OPTS flag:

  1. Check that the service also includes the FLAGS env (ideally, we should check that these flags are not present in the entrypoint.sh, but this might be more complex).
  2. Check that the package includes check_extra_opts.sh and that it follows the exact expected format
  3. Check that the last line of the entrypoint.sh follows the format `./command check_extra_opts(FLAGS, EXTRA_OPTS)
@dsimog01 dsimog01 added enhancement New feature or request P1 Has to be done but not urgent labels Mar 15, 2023
@pablomendezroyo
Copy link
Contributor

Hard to implement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 Has to be done but not urgent
Projects
None yet
Development

No branches or pull requests

2 participants