Skip to content

Commit 8966851

Browse files
RSDK-9423: Revert flag name change (viamrobotics#4638)
1 parent f7bf12c commit 8966851

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

.github/workflows/test-module-generation.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
- name: Run module generator
5050
run: |
5151
go run ./cli/viam --debug module generate \
52-
--module-name "my-module" \
52+
--name "my-module" \
5353
--language "${{ matrix.language }}" \
5454
--public-namespace "my-org" \
5555
--resource-subtype "${{ matrix.resource.subtype }}" \

cli/app.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ const (
4545
// TODO(RSDK-9287) - "name" occurs as three different flags. let's simplify that.
4646
apiKeyCreateFlagName = "name"
4747

48-
moduleFlagName = "module-name"
48+
moduleFlagName = "name"
4949
moduleFlagLanguage = "language"
5050
moduleFlagPublicNamespace = "public-namespace"
5151
moduleFlagPath = "module"

cli/module_generate.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ var (
4747
)
4848

4949
type generateModuleArgs struct {
50-
ModuleName string
50+
Name string
5151
Language string
5252
Public bool
5353
PublicNamespace string
@@ -73,7 +73,7 @@ func (c *viamClient) generateModuleAction(cCtx *cli.Context, args generateModule
7373
var err error
7474

7575
newModule = &modulegen.ModuleInputs{
76-
ModuleName: args.ModuleName,
76+
ModuleName: args.Name,
7777
Language: args.Language,
7878
IsPublic: args.Public,
7979
Namespace: args.PublicNamespace,

0 commit comments

Comments
 (0)