RSDK-9218: Move upload-artifacts to v4. (viamrobotics#4532)

Author: dgottlieb

.github/workflows/appimage.yml

@@ -124,7 +124,7 @@ jobs:
     # note: we do this because uname sees the arm64 kernel underneath the armhf container
     - name: fix platform detection
       run: mv bin/`uname -s`-`uname -m` bin/`uname -s`-armv7l
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
         name: appimage-static-32bit
         path: |
@@ -157,7 +157,7 @@ jobs:
         DPKG_ARCH: armhf
         APPIMAGE_ARCH: armhf
       run: make appimage-arch
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
         name: appimage-armhf
         path: etc/packaging/appimages/deploy

.github/workflows/droid.yml

@@ -53,7 +53,7 @@ jobs:
         BUILD_CHANNEL: ${{ inputs.release_type }}
       run: make server-android
 
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
         name: viam-server-android
         path: ${{ env.TARGET }}

.github/workflows/macos.yml

@@ -25,7 +25,7 @@ jobs:
         brew install ffmpeg
     - name: build
       run: go build ./web/cmd/server
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
         name: viam-server-macos
         path: server

.github/workflows/motion-benchmarks.yml

@@ -35,30 +35,30 @@ jobs:
 
     - name: Run motion quality tests on main branch
       shell: bash
-      env: 
+      env:
         URL: ${{ github.event.pull_request.base.repo.html_url }}
         SHA: ${{ github.event.pull_request.base.sha }}
       run: |
         cd motion-testing
         go mod edit -replace go.viam.com/rdk=${URL#"https://"}@$SHA
         sudo -Hu testbot bash -lc "go mod tidy && go test ./... -v -run TestDefault --name=$BASELINE"
-        
+
     - name: Run motion quality tests on PR branch
       shell: bash
-      env: 
+      env:
         URL: ${{ github.event.pull_request.head.repo.html_url }}
         SHA: ${{ github.event.pull_request.head.sha }}
       run: |
         cd motion-testing
         go mod edit -replace go.viam.com/rdk=${URL#"https://"}@$SHA
         sudo -Hu testbot bash -lc "go mod tidy && go test ./... -v -run TestDefault --name=$MODIFIED"
-        
+
     - name: Print results
       run: |
         cd motion-testing
         sudo -Hu testbot bash -lc "go test ./... -v -run TestScores --baselineDir=$BASELINE --modifiedDir=$MODIFIED"
         cat results/motion-benchmarks.md
- 
+
     # Now that RDK is public, can't directly comment without token having full read/write access
     # motion-benchmarks-comment.yml will trigger seperately and post the actual comments
 
@@ -67,7 +67,7 @@ jobs:
         echo "PR_NUMBER=${{ github.event.pull_request.number }}" >> pr.env
 
     - name: Upload results
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: pr-motion-benchmark
         path: |

.github/workflows/test.yml

@@ -78,7 +78,7 @@ jobs:
 
       - name: Upload test.json
         if: always()
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: test-${{ matrix.platform_name }}.json
           path: json.log
@@ -147,7 +147,7 @@ jobs:
           sudo --preserve-env=MONGODB_TEST_OUTPUT_URI,GITHUB_SHA,GITHUB_RUN_ID,GITHUB_RUN_NUMBER,GITHUB_RUN_ATTEMPT,GITHUB_X_PR_BASE_SHA,GITHUB_X_PR_BASE_REF,GITHUB_X_HEAD_REF,GITHUB_X_HEAD_SHA,GITHUB_REPOSITORY -Hu testbot bash -lc 'make cover-only'
 
       - name: Upload code coverage
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: pr-code-coverage
           path: |