Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoregister new handlers #8

Open
danryan opened this issue Jun 26, 2014 · 5 comments
Open

Autoregister new handlers #8

danryan opened this issue Jun 26, 2014 · 5 comments

Comments

@danryan
Copy link
Owner

danryan commented Jun 26, 2014

No description provided.

@danryan
Copy link
Owner Author

danryan commented Jul 6, 2014

groundwork laid by #16

@danryan
Copy link
Owner Author

danryan commented Jul 10, 2014

I'm not sold on this idea yet. Auto registration makes sense for adapters and stores but less sense for handlers as one presumably holds more control over the code.

Still, the idea is trivial enough. It could make consuming plugins from others easier. This might look like the register hooks for adapters/stores. Then again, the package system already manages this quit well.

Automatically adding them to the robot, however, will probably never happen.

@tcolgate
Copy link

This is easy enough to do from user side, and might be annoying if people don't want it (I've set this up in my own project)

@danryan
Copy link
Owner Author

danryan commented Nov 24, 2014

Hey, thanks for your input on this and other issues. I really appreciate it!

I agree with you. It's not difficult to add new handlers, and I appreciate the explicitness of adding them currently over an implicit registration. No surprises, less magic. A not found handler like #7 could provide a helpful error to log when a expected handler hasn't been loaded.

@tcolgate
Copy link

@danryan no probs, hal is looking nice. I had a dig around the various other similar projects (the code looks very similar to victor, are they related somehow?), hal came out on top. Would be nice to see a few more tests in the code, but it's definitely the easiest to get running with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants