-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TimeAgo pipe should work for valid string date #224
Comments
rahuldimri
added a commit
to rahuldimri/ngx-pipes
that referenced
this issue
Jun 14, 2022
It is common use-case to provide date as a valid string. Even the backend responses come as a plain string which represents the date.
I have modified the code and added the feature. |
Anyone wants to take this? |
I think you are the only one who is having write access 😀 |
@danrevah As I understand the solution is already prepared by @rahuldimri. Can it be integrated into the main code? |
Hello. Any updates about this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm submitting a ...
Current behavior
When passing a string to the timeAgo pipe, it returns invalid date even if the string correspond to a date.
Expected behavior
If the string is a valid date it should convert it to a date and act as if it was a date
Minimal reproduction of the problem with instructions
https://stackblitz.com/edit/angular-e5cldc?file=src/app/app.component.ts
The text was updated successfully, but these errors were encountered: