Skip to content

Latest commit

 

History

History
82 lines (57 loc) · 5.37 KB

CONTRIBUTING.md

File metadata and controls

82 lines (57 loc) · 5.37 KB
Raw

Contributing to Ax

We want to make contributing to this project as easy and transparent as possible.

Pull Requests

We actively welcome your pull requests.

  1. Fork the repo and create your branch from master. For the most seamless developer experience, we recommend that you install all optional dependencies for Ax.
  2. Please see the Code Requirements section for requirements on unit testing, code style, documentation, etc. These requirements are enforced via Travis for each PR.
  3. If you haven't already, complete the Contributor License Agreement ("CLA").

Contributor License Agreement ("CLA")

In order to accept your pull request, we need you to submit a CLA. You only need to do this once to work on any of Facebook's open source projects.

Complete your CLA here: https://code.facebook.com/cla

Issues

We use GitHub issues to track public bugs. Please ensure your description is clear and has sufficient instructions to be able to reproduce the issue.

Facebook has a bounty program for the safe disclosure of security bugs. In those cases, please go through the process outlined on that page and do not file a public issue.

Code Requirements

The Ax codebase has a high standard for code quality, which we enforce via Travis.

Coding Style

We use the Black code formatter for all Python files. You can install the latest release via pip install black and run it over the library via black ax.

Unit Tests

The majority of our code is covered by unit tests and we are working to get to 100% code coverage. Please ensure that new code is covered by unit tests. To run all unit tests, we recommend installing pytest using pip install pytest and running pytest -ra from the root of the Ax repo. To get coverage, pip install pytest-cov and run pytest -ra --cov=ax.

Linting

Run the linter via flake8 (pip install flake8) from the root of the Ax repository. Note that we have a custom flake8 configuration.

Static Type Checking

We use Pyre for static type checking and require code to be fully type annotated. At the moment, static type checking is not supported within Travis.

Documentation

  • We require docstrings on all public functions and classes (those not prepended with _).
  • We use the Google docstring style & use Sphinx to compile the complete API documentation.
  • To rule out parsing errors, you can run Sphinx from the Ax root via sphinx-build -WT sphinx/source sphinx/build. The -W flag will cause Sphinx to break on the first error.
  • If adding a new module to Ax, please add it to the appropriate Sphinx reStructuredText (rst) file (see here). We have a check in Travis for un-documented modules.

Website

The Ax website was created with Docusaurus, with heavy customization to support tutorials, complete API documentation via Sphinx, and versioning.

FontAwesome icons were used under the Creative Commons Attribution 4.0 International.

Local Building

You will need Node >= 8.x and Yarn >= 1.5 to build the Sphinx docs and Docusaurus site (which embeds the Sphinx docs inside). The following command will both build the docs and serve the (unversioned) site locally:

./scripts/make_docs.sh

Open http://localhost:3000 (if doesn't automatically open). Anytime you change the contents of the page, the page should auto-update.

To build a static version, add the -b flag.

Additional details:

  • This is the unversioned site built off of the current repository. Versioning is much more complex, and is generally not necessary for testing the site. Versioning is automatically handled when publishing the site to gh-pages.
  • Skipping Sphinx API & tutorials: to build the site without running Sphinx or compiling the tutorials, pass the -o flag to the make_docs.sh script. This is especially useful when you want to iterate quickly on making changes to the Docusaurus config and you've already run Sphinx and tutorial generation (the outputs are still in website subdirectory and will be picked up).
  • Tutorials: we embed tutorials written in Jupyter notebooks into the site. By default, these tutorials are converted to HTML without execution. However, you can execute all tutorials via ./scripts/make_docs.sh -t, optionally specifying the Jupyter kernel to use via -k [kernel_name]. If you do execute the tutorials, please keep in mind that the version of Ax you have installed should match the version of Ax you're trying to build tutorials for.

Publishing

The site is hosted as a GitHub page (on the gh-pages branch). We build the latest version of the site with every commit to the master branch via Travis. The latest version of the site can be manually updated using ./scripts/publish_site.sh (assuming proper credentials).

When new version of Ax rolls out, we add a new version to the site via ./scripts/publish_site.sh -v [version].

License

By contributing to Ax, you agree that your contributions will be licensed under the LICENSE file in the root directory of this source tree.