OnEvent(StateChanged)

[TomWocken]

My project uses AriModel and I've seen something unexpected.

pcModel->OnChannelStateChanged() works fine, but when I changed it to pcClient->OnEvent("StateChanged") those same events are never received. This was done to access the entire JsonTree.

I wouldn't think this is a conflict with AriModel since pcClient->OnEvent("PlaybackFinished") does work as expected.

On perhaps a related note, I have never gotten events with pcClient->OnEvent("ChannelTalkingStart") either.

I'd appreciate any thoughts on where these events might be getting lost.
I have updated to v1.1.0 and this issue still exists.

[daniele77]

I guess you want to use:

pcClient->OnEvent("ChannelStateChanged");

instead of:

pcClient->OnEvent("StateChanged");

Because StateChanged is not a valid ARI event.

However, Client::OnEvent() should be used only for events that have no explicit handler available in AriModel class.

As for as the ChannelTalkingStart event, you should check if it is fired by asterisk using e.g. this tool: https://github.com/daniele77/aritester

[TomWocken]

ChannelStateChanged didn't work either. I can go back to pcModel->OnChannelStateChanged() easily enough, I was just trying to get Json into a trace log for my own amusement.

It'll be some time before I can test TALK_DETECT again but last time asterisk debug logs showed lost event being put on the stasis bus.

[daniele77]

Can you try to add those events registration to the low_level_dial.cpp example that comes with the library?

[TomWocken]

Finally got back to testing and wanted to note that it helps to use ARI events instead of AMI.
ChannelTalkingStarted and ChannelTalkingFinished do work as expected.

[TomWocken]

Am I missing something or does OnPlaybackFinished handler not have access to media_uri or target_uri?

[daniele77]

Yes, currently OnPlaybackFinished passes a Playback object that only has the id of the media, just to be able to invoke the Stop method.
In the future, we surely are going to add all the missing info to the Playback class.

When you need events not handled by AriModel, you can adopt the low-level style, i.e., you don't instantiate AriModel altogether and instead register the events you need in Client. See low_level_dial.cpp in the example directory.

[TomWocken]

Thanks, I understand.
I would rather keep AriModel for all its functionality and either accept inefficiency of two handlers in Client::eventHandlers multimap or use Playback::Id() in OnPlaybackFinished lambda to look up my channels and bridges.
Unfortunately my old school company is fine with me using opensource projects but not contributing to them.

[TomWocken]

Is there actually any reason to Stop a playback that is already finished?

[daniele77]

Of course no.
But it doesn't hurt, either :-)
The library is designed to allow issuing commands even in states where the command is not valid (e.g., hangup of a dead channel). Asterisk simply ignores the command.
Perhaps it's not the most effective solution (in terms of performances), but it's really the simplest design in terms of development.
I guess in the future we'll try to add checks for these cases.

[TomWocken]

I doubt trying to mirror asterisk state in aricpp just to avoid overhead of sending commands is worth anyone's time.
Just glad I wasn't missing a leak of playback objects.