aricpp::Client websocket - what if the connection breaks?

[ferchor2003]

The aricpp::Client constructor creates a Websocket connection to get events from the Asterisk server. This is meant to be a long term connection to the server; however, in production environments the websocket can get disconnected. From that point on, no messages will be received from Asterisk.
Is there a way for the application to restore this socket connection?

I was looking at questions like this one on stackoverflow but I don't see a way to do that here.

[daniele77]

Have you tried doing again a client.Connect call after disconnection?

[ferchor2003]

I have. It needs to be preceded by a call to websocket.close().
I was thinking that maybe there's a way to add a asio task in the aricpp::Client to ping the websocket connection every few minutes(? seconds?) and restore the connection if it is broken. That's the direction I'm going right now...

[daniele77]

Ok @ferchor2003 .
Can you open an issue referencing this discussion, please?

[TomWocken]

The following code works for me when my ARI must wait to connect to Asterisk.
But is the error condition complete or robust? I can understand ENOTDIR but it does look weird.
Your discussion on Ping is interesting but beyond my requirements at this point.

function<void()> RetryConnect=[&]()
{
   pcClient->Connect([&](sys::error_code cError)
   {
      if (cError)
      {
         g_cLog.LogError("ARI client connect error (%d: %s)", cError.value(), cError.message().c_str());

         if ((cError.value() == sys::errc::connection_refused) // "Connection refused"
          || (cError.value() == sys::errc::not_a_directory))   // "The WebSocket handshake was declined by the remote peer"
         {
            pcClient->Close();
            cTimer.expires_after(chrono::seconds(10));
            cTimer.async_wait([&](boost::system::error_code cError)
            {
               if (cError)
               {
                  g_cLog.LogError("ARI client wait error (%d: %s)", cError.value(), cError.message().c_str());
                  pcIOService->stop();
               }
               else
               {
                  g_cLog.LogInfo("ARI client reconnecting to Asterisk");
                  RetryConnect();
               }
            });
         }
         else
         {
            pcIOService->stop();
         }
      }
      else
      {
         g_cLog.LogInfo("ARI client connected to Asterisk");
      }
   });
};
RetryConnect();

[daniele77]

I just committed a solution:
e3c4fa8
Now there is an optional parameter on Client::Connect that specifies the reconnection period in seconds.
Please, can you try it and give me feedback?
Thanks

[TomWocken]

Finally got a chance to test your code after some Houston weather and work distractions.
Everything worked as expected.
This project has also been my introduction to C++ >= 11 so having lambda repeat for errors was a happy feature.

Thanks

[daniele77]

That's great.
Thank you @TomWocken for your contribution.
I'm gonna release an official version as soon as possible.

[ferchor2003]

Great to know it is also working for you. I guess I have not said that the code is working for me too. Thanks!

[daniele77]

Thank you @ferchor2003 . All your feedback is valuable.