Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove post macro from api::core::emergency_access::post_emergency_access or add to routes! #4144

Closed
zacknewman opened this issue Dec 7, 2023 Discussed in #4076 · 1 comment · Fixed by #4143
Closed

Remove post macro from api::core::emergency_access::post_emergency_access or add to routes! #4144

zacknewman opened this issue Dec 7, 2023 Discussed in #4076 · 1 comment · Fixed by #4143

Comments

@zacknewman
Copy link
Contributor

Discussed in #4076

Originally posted by zacknewman November 16, 2023
api::core::emergency_access::post_emergency_access is only ever used once in put_emergency_access, and the Route is not added by routes! in routes. Three fixes are:

  • add the Route via routes! in routes.
  • Remove the post macro.
  • Remove the function altogether and integrate its body into put_emergency_access.
@zacknewman
Copy link
Contributor Author

zacknewman commented Dec 7, 2023 •
edited
Loading

Based on the most recent PR from @BlackDex, I think this got overlooked due to it being a Discussion and not Issue.

BlackDex added a commit to BlackDex/vaultwarden that referenced this issue Dec 7, 2023
@BlackDex
Add missing route
e85ecc4 
While there was a function and a derive, this endpoint wasn't part of
the routes. Since Bitwarden does have this endpoint ill add the route
instead of deleting it.

Fixes dani-garcia#4076
Fixes dani-garcia#4144
@BlackDex BlackDex mentioned this issue Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Several small fixes for open issues BlackDex/vaultwarden
1 participant
@zacknewman