Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file include support #9

Closed
lekhmanrus opened this issue Oct 11, 2018 · 1 comment
Closed

Add file include support #9

lekhmanrus opened this issue Oct 11, 2018 · 1 comment

Comments

@lekhmanrus
Copy link
Contributor

lekhmanrus commented Oct 11, 2018

It seems there are some issues with include operator support: https://pugjs.org/language/includes.html

include test

// pug code

test.pug:

p Simple test

Error:
image

Interesting that I'm including also file with all mixins definition, like:

include mixins

// pug code

and it works without errors.

P.S.: It worked with webpack and pug-html-loader (I had ejected webpack before). And now, after migration to Angular CLI and ng-cli-pug-loader, I have that error.

P.P.S.: Or maybe an error in pug-loader. Just noticed that I used pug-html-loader before migration.

@lekhmanrus
Copy link
Contributor Author

It seems it is pug-loader issue: pugjs/pug-loader#105

I think this issue can be closed now. Sorry for bothering you.

lekhmanrus pushed a commit to lekhmanrus/ng-cli-pug-loader that referenced this issue Oct 12, 2018
lekhmanrus pushed a commit to lekhmanrus/ng-cli-pug-loader that referenced this issue Oct 12, 2018
danguilherme added a commit that referenced this issue Oct 28, 2018
danguilherme added a commit that referenced this issue Oct 28, 2018
danguilherme pushed a commit that referenced this issue Oct 28, 2018
* fixes #9

* fixes #9 - improved e2e tests and added exclude to main pug rule

* Added: usage of pug include described in readme
danguilherme added a commit that referenced this issue Oct 28, 2018
* Support pug file include (fixes #9) (#10)

* fixes #9

* fixes #9 - improved e2e tests and added exclude to main pug rule

* Added: usage of pug include described in readme

* Run 'npm audit fix'

* Update test script
@danguilherme danguilherme changed the title Includes support Add file include support Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant