Remove dandiarchive-embargo bucket

[kabilar]

Hi @waxlamp @jjnesbitt, from what I understand, the embargo redesign moved all data to a single bucket (design doc). There are still references to the embargoed bucket:

dandi-infrastructure

• dandi-infrastructure/terraform/api.tf

  Line 31 in 25bfa80

  DJANGO_DANDI_DANDISETS_EMBARGO_BUCKET_NAME = module.sponsored_embargo_bucket.bucket_name

• dandi-infrastructure/terraform/staging_pipeline.tf

  Line 30 in 25bfa80

  DJANGO_DANDI_DANDISETS_EMBARGO_BUCKET_NAME = module.staging_embargo_bucket.bucket_name

• dandi-infrastructure/terraform/sponsored_bucket.tf

  Line 17 in 25bfa80

  bucket_name = "dandiarchive-embargo"

dandi-cli (tests)

• https://github.com/dandi/dandi-cli/blob/4d0d85bf48789c002b05bf43d340e21970108e96/dandi/tests/data/dandiarchive-docker/docker-compose.yml#L25

backups2datalad (tests)

• https://github.com/dandi/backups2datalad/blob/eb990ca3da3138039edce880e23800c6adc3fa47/test/data/dandiarchive-docker/docker-compose.yml#L21

Should these references be removed? If the embargoed bucket is not used anymore, I would suggest removing since this might be confusing for the EMBER team.

cc @aaronkanzer

[waxlamp]

Out of an abundance of caution, we have deliberately not destroyed the embargoed bucket yet. I've added it to the list of buckets slated for deletion.

When we have consensus that it's time to destroy these buckets, we can remove the references you've collected above.