Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Delta doesnt' show the entire diff #1780

Closed
CGamesPlay opened this issue Aug 2, 2024 · 2 comments
Closed

🐛 Delta doesnt' show the entire diff #1780

CGamesPlay opened this issue Aug 2, 2024 · 2 comments

Comments

@CGamesPlay
Copy link

$ delta --version
delta 0.17.0
$ cat diff.patch  | delta

Delta doesn't show the full patch. It stops after line 972 "Install the project...". The "---" lines look suspicious, but such lines appear elsewhere in the file (search "Enabling feature profiling") and work just fine. Snippet of where delta stops showing output:

-[ 87%] No install step for 'wasmtime-crate'
-[100%] Completed 'wasmtime-crate'
-[100%] Built target wasmtime-crate
-Install the project...
--- Install configuration: "Release"
--- Installing: /home/runner/work/wasmtime/wasmtime/target/c-api-install/include
--- Installing: /home/runner/work/wasmtime/wasmtime/target/c-api-install/include/wasm.h
--- Installing: /home/runner/work/wasmtime/wasmtime/target/c-api-install/include/wasmtime
--- Installing: /home/runner/work/wasmtime/wasmtime/target/c-api-install/include/wasmtime/async.h
--- Installing: /home/runner/work/wasmtime/wasmtime/target/c-api-install/include/wasmtime/profiling.h
--- Installing: /home/runner/work/wasmtime/wasmtime/target/c-api-install/include/wasmtime/global.h

diff.patch

@sskras
Copy link

sskras commented Aug 2, 2024

I wonder if that has to do something with ANSI escape sequences occuring after the initial - a few lines below. Eg:

  ...
--- Installing: /home/runner/work/wasmtime/wasmtime/target/c-api-install/../c-api-install/lib/libwasmtime.so
--- Installing: /home/runner/work/wasmtime/wasmtime/target/c-api-install/../c-api-install/lib/libwasmtime.a
-##[group]Run ./ci/build-tarballs.sh "x86_64-android" "x86_64-linux-android"
-�[36;1m./ci/build-tarballs.sh "x86_64-android" "x86_64-linux-android"�[0m
  ...

@th1000s
Copy link
Collaborator

th1000s commented Aug 4, 2024

It's much simpler, diff -u .. input starts with (in this case) --- /var/folder/... to describe the original filenames, but removing a line starting with -- (in this case -- Enabling feature profiling) creates a line that delta handles like a filename which results in garbled output.

Fixed in #1787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants