From 96d7b3e8128c3802b1708fff767691d3a629fc81 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Carlos=20Cola=C3=A7o?= <coolapso@coolapso.tech>
Date: Sat, 20 Jul 2024 18:28:46 +0200
Subject: [PATCH] fix(logging): Log request errors

fix #61, log when request status code is not 200
adjust wording on logs easier understand what's causing the log message
---
 twitch_exporter.go | 26 +++++++++++++++++++++++---
 1 file changed, 23 insertions(+), 3 deletions(-)

diff --git a/twitch_exporter.go b/twitch_exporter.go
index c6694f8..043ddd7 100644
--- a/twitch_exporter.go
+++ b/twitch_exporter.go
@@ -146,6 +146,11 @@ func (e *Exporter) Collect(ch chan<- prometheus.Metric) {
 		return
 	}
 
+	if streamsResp.StatusCode != 200 { 
+		level.Error(e.logger).Log("msg", "Failed to collect stats from Twitch helix API", "err", streamsResp.ErrorMessage)
+		return
+	}
+
 	for _, stream := range streamsResp.Data.Streams {
 		gamesResp, err := e.client.GetGames(&helix.GamesParams{
 			IDs: []string{stream.GameID},
@@ -172,17 +177,27 @@ func (e *Exporter) Collect(ch chan<- prometheus.Metric) {
 		Logins: *twitchChannel,
 	})
 	if err != nil {
-		level.Error(e.logger).Log("msg", "Failed to collect stats from Twitch helix API", "err", err)
+		level.Error(e.logger).Log("msg", "Failed to collect users stats from Twitch helix API", "err", err)
 		return
 	}
+
+	if usersResp.StatusCode != 200 { 
+			level.Warn(e.logger).Log("msg", "Failed to collect users stats from Twitch helix API", "err", usersResp.ErrorMessage)
+	}
+
 	for _, user := range usersResp.Data.Users {
 		usersFollowsResp, err := e.client.GetChannelFollows(&helix.GetChannelFollowsParams{
 			BroadcasterID: user.ID,
 		})
 		if err != nil {
-			level.Error(e.logger).Log("msg", "Failed to collect stats from Twitch helix API", "err", err)
+			level.Error(e.logger).Log("msg", "Failed to collect follower stats from Twitch helix API", "err", err)
 			return
 		}
+
+		if usersFollowsResp.StatusCode != 200 { 
+			level.Warn(e.logger).Log("msg", "Failed to collect follower stats from Twitch helix API", "err", usersFollowsResp.ErrorMessage)
+		}
+
 		if _, ok := channelsLive[user.DisplayName]; !ok {
 			ch <- prometheus.MustNewConstMetric(
 				channelUp, prometheus.GaugeValue, 0,
@@ -201,9 +216,14 @@ func (e *Exporter) Collect(ch chan<- prometheus.Metric) {
 			BroadcasterID: user.ID,
 		})
 		if err != nil {
-			level.Error(e.logger).Log("msg", "Failed to collect stats from Twitch helix API", "err", err)
+			level.Error(e.logger).Log("msg", "Failed to collect subscribers stats from Twitch helix API", "err", err)
 			return
 		}
+
+		if subscribtionsResp.StatusCode != 200 { 
+			level.Warn(e.logger).Log("msg", "Failed to collect subscirbers stats from Twitch helix API", "err", subscribtionsResp.ErrorMessage)
+		}
+
 		subCounter := make(map[string]int)
 		giftedSubCounter := make(map[string]int)
 		for _, subscription := range subscribtionsResp.Data.Subscriptions {