-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TachoPPR not working with float value #145
Comments
Which vehicle needs a decimal pulse per revolution? Please add some info. Most Speedos work off of ignition pulses so they would be multiples and not fractions. |
I use this to drive the speedometer to show vehicle speed. Think the code whas make to drive to tachometer, because of the 750 min and 7500 max. But sins the variable is declared as a float and the web interface is a float. I assumed that was meant to be a float. |
Yea the web interfaces makes everything a float. I do not agree with doing that. Yes it is to drive a tachometer. Could look at introducing an option to have it behave as a speedometer. Proposal, new output type:
|
Tom, |
Some tach signals are used to enable things like power steering ect. Will look at adding the "speedometer" output that allows you to do a tach that shows actual rpm. |
A speedo type would be good. I have it set to start form 5 km/h. To avoid the speedo jumping at low speed. I think the timer might be loaded with more than 16 bits. could not find a clear datasheet on the timer. The tach starting from 750 seems good to me. Can act like drive enable indicator |
Gents pull request is made #158 I bench tested this, it only work on Vehicle set to Classic Will close once other test |
currently the TachoPPR value is read as a INT
utils.cpp line 569 in void SpeedoSet(uint16_t speed)
should change to:
float PulseGain = Param::GetFloat(Param::TachoPPR);
The text was updated successfully, but these errors were encountered: