Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the ProjectiveNielsPoint mapping relationship in the document written incorrectly? #597

Open
zjsec opened this issue Nov 3, 2023 · 0 comments

Comments

@zjsec
Copy link

zjsec commented Nov 3, 2023

The document states as follows:
DOC1 ProjectiveNielsPoint: $(Y+X,Y−X,Z,2dXY)$
DOC2 "..., represented as $(Y+X,Y-X,Z,2dXY)$ in ‘Niels coordinates’."

But the relevant code is as follows:

T2d: &self.T * &constants::EDWARDS_D2,

impl EdwardsPoint {
    /// Convert to a ProjectiveNielsPoint
    pub(crate) fn as_projective_niels(&self) -> ProjectiveNielsPoint {
        ProjectiveNielsPoint {
            Y_plus_X: &self.Y + &self.X,
            Y_minus_X: &self.Y - &self.X,
            Z: self.Z,
            T2d: &self.T * &constants::EDWARDS_D2,
        }
    }
}

We know that in the $\mathbb{P}^3$ model, $XY=ZT$, so $XY$ is not equal to $T$.
Is it a document error?
Is it correct to change to $(Y-X, Y+X, Z, 2dT)$?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant