Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simd_backend: replace packed_simd_2 with std::simd #415

Closed
tarcieri opened this issue Oct 18, 2022 · 3 comments
Closed

simd_backend: replace packed_simd_2 with std::simd #415

tarcieri opened this issue Oct 18, 2022 · 3 comments

Comments

@tarcieri
Copy link
Contributor

The packed_simd_2 crate used by the simd_backend feature is a prototype of std::simd, which has since landed in the nightly compiler, making packed_simd_2 effectively obsolete.

It would probably be a good idea to migrate simd_backend to use std::simd.

@rozbb rozbb added the do-for-4.0 This should be resolved before we do a 4.0 release label Oct 18, 2022
@rozbb
Copy link
Contributor

rozbb commented Oct 22, 2022

Looked into this and it seems like a pretty nontrivial change. Some traits aren't implemented (e.g., going from Simd<u32, 8> to a Simd<u64, 4>), shifting like Shl<u8> for Simd<u64, 4>, and extracting lanes Simd<u32, 8>::extract.

Maybe it'd be best to remove the do-for-4.0?

@tarcieri
Copy link
Contributor Author

Sure

@rozbb rozbb removed the do-for-4.0 This should be resolved before we do a 4.0 release label Oct 22, 2022
@tarcieri
Copy link
Contributor Author

tarcieri commented Apr 2, 2023

I consider this addressed by #520.

An eventual migration to std::simd would probably make sense, but in the meantime, this has removed the pack_simd_2 dependency and better yet made everything work on stable (where std::simd is currently nightly-only).

@tarcieri tarcieri closed this as completed Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants