Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with <br/> and capitals #603

Open
PaulRambags opened this issue Jun 4, 2021 · 2 comments
Open

Issue with <br/> and capitals #603

PaulRambags opened this issue Jun 4, 2021 · 2 comments

Comments

@PaulRambags
Copy link

PaulRambags commented Jun 4, 2021

Expected Behavior

We try to process the following DTBook paragraph:
<p>A<br/>Aa</p>

The expected output would be:
expected

or, {capital mark}A{line-break}{capital mark}Aa

Actual Behavior

This is the actual erroneous output.
actual

or, {permanent capital mark}A{line-break}a{recovery sign}a

Steps to Reproduce

  1. Take an abritrary existing DTBook
  2. Add this paragraph: <p>A<br/>Aa</p>

Details

None.

Environment

  • Operating system: Windows 10 64-bit
  • DAISY Pipeline 2 version (modules-parent): 1.14.1
  • Interface: Command Line
  • Language: nl

Logs

Relevant fragment from the generated OBFL:

<marker class="resumed-title/if-not-set-next" value=""/>⠘⠁<br/>⠁⠠⠁</block>

The generated OBFL already contains the mistake. This indicates that it is a Pipeline issue (and not an issue in Dotify).

@bertfrees
Copy link
Member

This was fixed when we upgraded to Dotify 1.0.1 (daisy/pipeline-modules@fe3a41c)

@bertfrees bertfrees reopened this Apr 1, 2022
@bertfrees
Copy link
Member

Not completely fixed yet because with pre-translation enabled the translation will still be wrong.

@bertfrees bertfrees modified the milestones: v1.14.4, Next May 9, 2023
@bertfrees bertfrees modified the milestones: Next, v1.14.13 May 23, 2023
@bertfrees bertfrees modified the milestones: v1.14.13, v1.14.14 Jun 13, 2023
@bertfrees bertfrees modified the milestones: v1.14.14, v1.14.16 Oct 16, 2023
@bertfrees bertfrees modified the milestones: v1.14.16, v1.14.17 Dec 1, 2023
@bertfrees bertfrees modified the milestones: v1.14.17, v1.14.18 Jan 3, 2024
@bertfrees bertfrees removed this from the v1.14.18 milestone Apr 19, 2024
bertfrees added a commit that referenced this issue May 28, 2024
Inline ::before and ::after pseudo-elements are now taken into account
when pre-translating the containing element.

'content' properties that are not inside a ::before or ::after
pseudo-element, or that are inside a ::before or ::after
pseudo-element stacked onto a different kind of pseudo-element or
other rule, are now not pre-translated anymore.

Fixes issues #652 and
#603.
bertfrees added a commit that referenced this issue May 28, 2024
Inline ::before and ::after pseudo-elements are now taken into account
when pre-translating the containing element.

'content' properties that are not inside a ::before or ::after
pseudo-element, or that are inside a ::before or ::after
pseudo-element stacked onto a different kind of pseudo-element or
other rule, are now not pre-translated anymore.

Fixes issues #652 and
#603.
bertfrees added a commit that referenced this issue Aug 15, 2024
Inline ::before and ::after pseudo-elements are now taken into account
when pre-translating the containing element.

'content' properties that are not inside a ::before or ::after
pseudo-element, or that are inside a ::before or ::after
pseudo-element stacked onto a different kind of pseudo-element or
other rule, are now not pre-translated anymore.

Fixes issues #652 and
#603.
bertfrees added a commit that referenced this issue Nov 1, 2024
Inline ::before and ::after pseudo-elements are now taken into account
when pre-translating the containing element.

'content' properties that are not inside a ::before or ::after
pseudo-element, or that are inside a ::before or ::after
pseudo-element stacked onto a different kind of pseudo-element or
other rule, are now not pre-translated anymore.

Fixes issues #652 and
#603.
bertfrees added a commit that referenced this issue Nov 21, 2024
Inline ::before and ::after pseudo-elements are now taken into account
when pre-translating the containing element.

'content' properties that are not inside a ::before or ::after
pseudo-element, or that are inside a ::before or ::after
pseudo-element stacked onto a different kind of pseudo-element or
other rule, are now not pre-translated anymore.

Fixes issues #652 and
#603.
bertfrees added a commit to daisy/pipeline-modules that referenced this issue Jan 4, 2025
Inline ::before and ::after pseudo-elements are now taken into account
when pre-translating the containing element.

'content' properties that are not inside a ::before or ::after
pseudo-element, or that are inside a ::before or ::after
pseudo-element stacked onto a different kind of pseudo-element or
other rule, are now not pre-translated anymore.

Fixes issues daisy/pipeline#652 and
daisy/pipeline#603.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants