Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add versions to github.com imports #13

Open
bertfrees opened this issue Jun 1, 2017 · 0 comments
Open

Add versions to github.com imports #13

bertfrees opened this issue Jun 1, 2017 · 0 comments

Comments

@bertfrees
Copy link
Member

bertfrees commented Jun 1, 2017 •
edited
Loading

The code has code like this:

import (
    "github.com/capitancambio/go-subcommand"
)

These dependencies are fetched in the Makefile, but it seems that no version is declared. Shouldn't there be a version so that the build is stable? If it is not possible to specify a version maybe we could also just include the dependencies in the source.

Links:
bertfrees added a commit that referenced this issue Nov 30, 2018
@bertfrees
Include go-subcommand as a subrepo
22afada 
... until we have found a better solution for
#13.

subrepo:
  subdir:   "libs/go-subcommand"
  merged:   "4b3fc5651c"
upstream:
  origin:   "https://github.com/capitancambio/go-subcommand.git"
  branch:   "master"
  commit:   "4b3fc5651c"
git-subrepo:
  version:  "0.3.1"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "a7ee886"
bertfrees added a commit that referenced this issue Nov 30, 2018
@bertfrees
Include blackterm as a subrepo
90d266e 
... until we have found a better solution for
#13.

subrepo:
  subdir:   "libs/blackterm"
  merged:   "8446c9dfde"
upstream:
  origin:   "https://github.com/capitancambio/blackterm.git"
  branch:   "master"
  commit:   "8446c9dfde"
git-subrepo:
  version:  "0.3.1"
  origin:   "???"
  commit:   "???"
@bertfrees bertfrees mentioned this issue Jan 17, 2019
Closed
bertfrees added a commit that referenced this issue Feb 5, 2019
@bertfrees
Include go-subcommand as a subrepo
6ac102c 
... until we have found a better solution for
#13.

subrepo:
  subdir:   "libs/go-subcommand"
  merged:   "4b3fc5651c"
upstream:
  origin:   "https://github.com/capitancambio/go-subcommand.git"
  branch:   "master"
  commit:   "4b3fc5651c"
git-subrepo:
  version:  "0.3.1"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "a7ee886"
bertfrees added a commit that referenced this issue Feb 5, 2019
@bertfrees
Include blackterm as a subrepo
ab64d6a 
... until we have found a better solution for
#13.

subrepo:
  subdir:   "libs/blackterm"
  merged:   "8446c9dfde"
upstream:
  origin:   "https://github.com/capitancambio/blackterm.git"
  branch:   "master"
  commit:   "8446c9dfde"
git-subrepo:
  version:  "0.3.1"
  origin:   "???"
  commit:   "???"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bertfrees