Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation Functionality #43

Closed
ivanstojkovicapps opened this issue Feb 22, 2017 · 23 comments
Closed

Animation Functionality #43

ivanstojkovicapps opened this issue Feb 22, 2017 · 23 comments

Comments

@ivanstojkovicapps
Copy link

Hi,

is there any implemented animation functionality?

best regards Ivan

@daimajia
Copy link
Owner

Animation? What kind of animation?

@ivanstojkovicapps
Copy link
Author

ivanstojkovicapps commented Feb 22, 2017

like when activity starts that progress bar goes from 0 to X %.
Currently i am doing it with:

Timer timer = new Timer();
    timer.schedule(new TimerTask() {
      @Override
      public void run() {
        activity.runOnUiThread(new Runnable() {
          @Override
          public void run() {
            if(progressBar.getProgress() < maxPercent) {
              progressBar.incrementProgressBy(1);
            }
          }
        });
      }
    }, 1000, 20);

One more thing, why is last release 1.2 from 2014, there are no attributes like

custom:progress_unreached_bar_height="4dp"
                    custom:progress_reached_bar_height="8dp"
                    custom:progress_text_size="16dp"
                    custom:progress="0"

in current version 1,2

@daimajia
Copy link
Owner

Transition animation will be supported in next version. Currently not support.

@daimajia
Copy link
Owner

Thanks for your advice.

@ivanstojkovicapps
Copy link
Author

Thanks! Nice Work.

Is there any reason that last release is from 2014. What is the latest version that should be used in gradle?

@daimajia
Copy link
Owner

Ha, there happened a lot of things since 2014. Too busy to take care my open source projects. But now, I think I'm back. 🎉

@daimajia
Copy link
Owner

There is a PR #35 which archived what you want, but I can't merge it, because It may get error or bad effect in some cases. It's not perfect enough.

@daimajia
Copy link
Owner

BTW. You can always get the version info here : http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22com.daimajia.numberprogressbar%22

@ivanstojkovicapps
Copy link
Author

is there a way to tell gradle to use last commit and not release 1.2?

@daimajia
Copy link
Owner

@ivanstojkovicapps Change 1.2 -> 1.1

@ivanstojkovicapps
Copy link
Author

ivanstojkovicapps commented Feb 22, 2017

Thanks, i tried this
compile 'com.daimajia.numberprogressbar:library:1.1'

Error:Execution failed for task ':app:processDebugManifest'.
Manifest merger failed : Attribute application@icon value=(@mipmap/ic_launcher) from AndroidManifest.xml:9:9-43
  	is also present at [com.daimajia.numberprogressbar:library:1.1] AndroidManifest.xml:4:45-81 value=(@drawable/ic_launcher).
  	Suggestion: add 'tools:replace="android:icon"' to <application> element at AndroidManifest.xml:6:5-25:19 to override.

@daimajia
Copy link
Owner

Oh, it's an old bug, better not use 1.1 anymore.

@ivanstojkovicapps
Copy link
Author

so you suggest: compile 'com.daimajia.numberprogressbar:library:1.2'
but there is a problem that the attributes are not working, when i use 1.2

@daimajia
Copy link
Owner

@ivanstojkovicapps which attribute? unreachedHeight ?

@ivanstojkovicapps
Copy link
Author

custom:progress_unreached_bar_height="4dp"
                    custom:progress_reached_bar_height="8dp"
                    custom:progress_text_size="16dp"
                    custom:progress="0"

@ivanstojkovicapps
Copy link
Author

none of those is working and there are no methods to set it programatically

@daimajia
Copy link
Owner

image

Make sure that you have added the highlight line in XML file. I just tested, it works well.

@daimajia
Copy link
Owner

xmlns:custom="http://schemas.android.com/apk/res-auto"

@ivanstojkovicapps
Copy link
Author

thanks, that was set wrong! Great!

@daimajia
Copy link
Owner

Version 1.3 has been released, please try the latest version of this lib. Lots of issues has been fixed.

@ivanstojkovicapps
Copy link
Author

thanks already got it!

@daimajia
Copy link
Owner

This thread will be closed, the feature will be archived in next version, thanks for your feedback. Have a nice day.

@Coehill
Copy link

Coehill commented May 1, 2018

@daimajia Hey did animation functionality get completed? If so, how does one use it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants