Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Do not install dagger CLI on runner if already present in PATH unless version: specified and different from installed version #164

Open
jpadams opened this issue Nov 20, 2024 · 2 comments · May be fixed by #167
Open

✨ Do not install dagger CLI on runner if already present in PATH unless version: specified and different from installed version #164

jpadams opened this issue Nov 20, 2024 · 2 comments · May be fixed by #167

Comments

@jpadams
Copy link
Contributor

jpadams commented Nov 20, 2024

What are you trying to do?

If a GHA runner has dagger CLI pre-installed, the action does not need to install it and should not do so unless the user asks for a particular version like with version: "0.13.7" AND that requested version is different from the already-installed version.

Why is this important to you?

How are you currently working around this?
@jpadams jpadams mentioned this issue Nov 20, 2024
Open
@jedevc
Copy link
Member

jedevc commented Nov 20, 2024

We actually do this already in dagger/dagger: https://github.com/dagger/dagger/blob/9e0f6aa9eadc90da9f8646726ac4d3ce16b43b69/.github/actions/call/action.yml#L43-L60

We should just be able to grab this logic from there.

@gerhard
Copy link
Member

gerhard commented Dec 11, 2024

LGTM!

This was referenced Dec 22, 2024
Draft
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: check for pre-installed dagger dagger/dagger-for-github
3 participants
@gerhard @jpadams @jedevc