Skip to content

Unit tests are failing #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
d6y opened this issue Sep 18, 2013 · 1 comment
Closed

Unit tests are failing #2

d6y opened this issue Sep 18, 2013 · 1 comment
Assignees
@d6y

Comments

@d6y
Copy link
Owner

d6y commented Sep 18, 2013

Perhaps we should just give up and use the Java bindings....

 Failed: : Total 36, Failed 7, Errors 0, Passed 29, Skipped 0

As spotted by anurag#18 (comment)
d6y added a commit that referenced this issue Sep 18, 2013
@d6y
Fix for #2 - added Stripe API version header to all requests, which a…
dd9854b 
…llows unit tests to pass.

The version is "2012-11-07". NB: the build produced from "sbt package" will be of the form: stripe-scala_2.9.2-2012.11.07.jar
@ghost ghost assigned d6y Sep 18, 2013
@d6y
Copy link
Owner Author

d6y commented Sep 18, 2013

Not sure on the best way to handle the Stripe version updates. My current best idea would be to publish this library for a known version ( 2012-11-07), enhance for more recent versions and publish that too.

Tested with sbt +test which runs against 2.9.1, 2.9.2 and 2.10.

@d6y d6y closed this as completed Sep 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d6y d6y

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@d6y