Automation: Improve reliability one Android 14 devices (OnePlus & Redmi) #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop using the root from accessibility events as fallback. Delayed event emission can lead to an out-dated (and later recycled) root being used by the step-process. Error behavior: * Click event from app 1 is emitted when SD Maid starts processing app 2 * windowRoot of app 2 is not ready yet * SD Maid starts using fallback root from the last event (the click event from app 2) * The fallback root is no longer valid, as it corresponds to the settings screen from app 1 * SD Maids keeps retrying and the fallback root is at some point recycled * SD Maid keeps trying to crawl an empty root nodef Fixes #1124 Might fix #1016
d4rken
added
bug
… and we previously didn't notice this not working because of the default flags, let's null the defaults to make this error case more obvious. This might also make the accessibility service less intrusive as the defaults will mean less info is provided when there is no automation task active in SD Maid.
…ondition anymore.
…YPE_WINDOW_STATE_CHANGED events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop using the root from accessibility events as fallback if
rootInActiveWindowis null.Delayed event emission can leave us with an out-dated (and later recycled) root node being used by the
StepProcessor.Error behavior:
Fixes #1124
Might fix #1016