Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button to open an app in the app store #158

Open
Wjxfi opened this issue Nov 28, 2022 · 4 comments
Open

Button to open an app in the app store #158

Wjxfi opened this issue Nov 28, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@Wjxfi
Copy link

Wjxfi commented Nov 28, 2022

pname+

it allows you to open an application by package name through any app store (f-droid, play market, droid-ify, aurora store, etc.).

https://github.com/bndeff/pname

https://play.google.com/store/apps/details?id=app.pname

just use his code

@d4rken d4rken added the enhancement New feature or request label Nov 28, 2022
@d4rken
Copy link
Member

d4rken commented Nov 28, 2022

How do we ensure that the app we are linking to is legitimate?

Let's say "some.app.pkg.name" is not on Google Play, now we check that there is an app with that packagename on on another App Store, someone could have squatted that name and the APK is at best something else and at worst malicious 🤔

Installing would only be possible if the signatures match hm 🤔 is that enough?

@Wjxfi
Copy link
Author

Wjxfi commented Nov 29, 2022

How do we ensure that the app we are linking to is legitimate?

Let's say "some.app.pkg.name" is not on Google Play, now we check that there is an app with that packagename on on another App Store, someone could have squatted that name and the APK is at best something else and at worst malicious 🤔

Installing would only be possible if the signatures match hm 🤔 is that enough?

it's impossible to forge package names in the app stores, don't worry.

@Wjxfi
Copy link
Author

Wjxfi commented Nov 29, 2022

You don't know how it works, and I've checked how it works, so don't tell me it can be tampered with.

it will open the one you want, but if you select a different app store than the one you downloaded the app from, it won't find it

@d4rken
Copy link
Member

d4rken commented Nov 30, 2022

it's impossible to forge package names in the app stores, don't worry.

It definitely is possible. Package names are not globally unique. They are unique per app store. Though it's likely not as critical as I thought and we could just use the market:// prefix as fallback for app store packages:

interface AppStore : Pkg {
val urlGenerator: ((Pkg.Id) -> String)?
get() = null
}

On a side note, I suggest you change your tone to be a bit more friendly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants