-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] highlight areas that have been reviewed #96
Comments
Hey @keesj-exset . Sorry for the late response. |
For your second part: I like the Idea, but I am unsure how it could be acheived / displayed after mark an area as reviewed.
So lot's of things to consider. Do you have some Ideas already? |
Hi,
I think the nicest solution for marking reviews is to not highlight the code but like the git plugin to add a line to the vertical ruler. https://stackoverflow.com/questions/29968499/vertical-rulers-in-visual-studio-code
I think that statistics would be the best approach e.g. 2000 lines of code reviews and 3 high priority bugs found
Yes... I do not have a clean answer to this.
I am currently still using the git code annotate approach e.g. modify the files and commit in a separate branch e.g. https://github.com/x7-labs/git-code-annotate. For that the solution would be to and an annotation at the start of the method stating the method has been reviewed (with a line count). but .. it is not the best solution either. |
I think this is a super valuable feature for people who do code reviews on a regular basis! |
🧩 Feature
Currently it is needed to go through the extension's review page but it would be nice when opening code to see the annotation either inline or marked on the left scrollbar like is done for pending code changes or git modifications that need to be committed.
At the same time it would be nice to be able to mark areas as "reviewed" without any note. Just marking the area as such.
The text was updated successfully, but these errors were encountered: