rename whitelist to allow (#67)

jennifer-shehane · web-flow · commit d4263fb1cdf3 · 2020-06-25T10:05:39.000-04:00
diff --git a/README.md b/README.md
@@ -40,7 +40,7 @@ You can add rules:
 }
 ```
 
-You can whitelist globals provided by Cypress:
+You can allow certain globals provided by Cypress:
 
 ```json
 {
diff --git a/lib/rules/no-assigning-return-values.js b/lib/rules/no-assigning-return-values.js
@@ -39,7 +39,7 @@ module.exports = {
   },
 }
 
-const whitelistedCommands = {
+const allowedCommands = {
   now: true,
   spy: true,
   state: true,
@@ -61,7 +61,7 @@ function isCypressCommandDeclaration (declarator) {
 
   const parent = get(object, 'parent.property.name') || get(declarator, 'id.name')
 
-  if (commandName && (whitelistedCommands[commandName] || whitelistedCommands[parent])) return
+  if (commandName && (allowedCommands[commandName] || allowedCommands[parent])) return
 
   return object.name === 'cy'
 }

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ You can add rules:`
`40`	`40`	`}`
`41`	`41`	```
`42`	`42`
`43`		`-You can whitelist globals provided by Cypress:`
	`43`	`+You can allow certain globals provided by Cypress:`
`44`	`44`
`45`	`45`	```json
`46`	`46`	`{`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ module.exports = {`
`39`	`39`	`},`
`40`	`40`	`}`
`41`	`41`
`42`		`-const whitelistedCommands = {`
	`42`	`+const allowedCommands = {`
`43`	`43`	`now: true,`
`44`	`44`	`spy: true,`
`45`	`45`	`state: true,`
`@@ -61,7 +61,7 @@ function isCypressCommandDeclaration (declarator) {`
`61`	`61`
`62`	`62`	`const parent = get(object, 'parent.property.name') \|\| get(declarator, 'id.name')`
`63`	`63`
`64`		`- if (commandName && (whitelistedCommands[commandName] \|\| whitelistedCommands[parent])) return`
	`64`	`+ if (commandName && (allowedCommands[commandName] \|\| allowedCommands[parent])) return`
`65`	`65`
`66`	`66`	`return object.name === 'cy'`
`67`	`67`	`}`