fix: make sure script and stack are both decoded before comparing #31037
+21
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
force-pushed
the
fix/em_dash_priv_command
branch
from
f8cfff3 to
2df81c1
Compare
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
fix/em_dash_priv_command
|
| Run status |
|
| Run duration | 17m 18s |
| Commit |
|
| Committer | AtofStryker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
28
|
Skipped
|
0
|
Passing
|
762
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
63.64%
|
|
|---|---|
|
Untested elements
|
30
|
|
Tested elements
|
56
|
Accessibility
96.18%
|
|
|---|---|
|
Failed rules
|
0 critical
4 serious
1 moderate
0 minor
|
|
Failed elements
|
197
|
AtofStryker
force-pushed
the
fix/em_dash_priv_command
branch
from
2df81c1 to
57de5d5
Compare
…v channel. If decode sequencing fails, return false
AtofStryker
force-pushed
the
fix/em_dash_priv_command
branch
from
57de5d5 to
9c06d2a
Compare
jennifer-shehane
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
With
14.0.2, we attempted to fix the privileged command channel by encoding the script uri to more accurately compare apples to apples when checking where the privileged command was invoked. However, the stack traces are not exactly encoded exactly to the specification, which caused other errors when trying to check the privileged command.To solve this, we are going to try comparing apples to apples via decoding the stack and the script name, so the text comparisons should match.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?