Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import wallet by xPriv #968

Open
sashapetrovska opened this issue Aug 20, 2024 · 4 comments
Open

Import wallet by xPriv #968

sashapetrovska opened this issue Aug 20, 2024 · 4 comments

Comments

@sashapetrovska
Copy link

Hi, I fell in love with the project and I'm really looking forward to it, but I've got kinda dissapointed that I couldn't import some of my wallets which I don't know the pp and only have the xpriv. The app would be really complete if it had import by xpriv support, also if I have some free time I'd like to send a PR if needed.

kind regards.

@sneurlax
Copy link
Member

sneurlax commented Aug 20, 2024

You're more than welcome to submit a PR @sashapetrovska and I or another dev will be happy to review it. We use a customized fork of peercoin/coinlib which can be found here:

https://github.com/cypherstack/coinlib

Using (and/or forking this to add any missing functionality) would be the preferred route to take to add this.

I think it would use either a MultiAddressInterface or something like a (but probably something similar to a PrivateKeyInterface). Unfortunately we can't generate a seed from an xpriv because xprivs imply a specific derivation path and are derived via mnemonic recovery phrase -> seed -> xpriv so they have to be handled, saved, backed up to and restored from Stack Wallet Backups separately/specially

@sneurlax
Copy link
Member

@sashapetrovska
Copy link
Author

sashapetrovska commented Aug 20, 2024

@sneurlax Thanks, I'll look into, also maybe should I open a new issue but it's me or when I change the derivation path to /84, the balance of the funds isn't shown?

@sneurlax
Copy link
Member

Sorry, I don't understand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants