Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suicide trigger prevents cycles starting #6594

Open
wxtim opened this issue Feb 7, 2025 · 4 comments · May be fixed by #6602
Open

Suicide trigger prevents cycles starting #6594

wxtim opened this issue Feb 7, 2025 · 4 comments · May be fixed by #6602
Assignees
Labels
bug Something is wrong :( investigation
Milestone

Comments

@wxtim
Copy link
Member

wxtim commented Feb 7, 2025

Description

User reported this case. It's not a blocker (for that user), because the user was over-using suicide triggers and we were able to remove the offending graph section. Nonetheless, this is a bug.

Reproducible Example

The following workflow will shut down as completed after all 1990's tasks are complete:

[scheduler]
    allow implicit tasks = True
    cycle point format = %Y

[scheduling]
    initial cycle point = 1990
    final cycle point = 1992
    [[graph]]
        R1 = install_cold
        P1Y = """
            install_cold[^] => foo? => bar?

            # The line below stops cycle points 1991 and 1992
            # from starting:
            bar:fail? => !foo?
        """

Expected Behaviour

Behaviour should be unchanged with or without the second graph line (assuming bar succeeds): 1991/2 should run the same graph again.

@wxtim wxtim added bug Something is wrong :( investigation labels Feb 7, 2025
@wxtim wxtim added this to the 8.4.1 milestone Feb 7, 2025
@oliver-sanders

This comment has been minimized.

@wxtim

This comment has been minimized.

@wxtim
Copy link
Member Author

wxtim commented Feb 7, 2025

The output of cylc graph looks correct.

@wxtim
Copy link
Member Author

wxtim commented Feb 7, 2025

Conceivably the same issue as #5945 and #5730

@wxtim wxtim linked a pull request Feb 10, 2025 that will close this issue
8 tasks
@oliver-sanders oliver-sanders modified the milestones: 8.4.1, 8.4.x Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :( investigation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants