Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't record satisfied clock triggers in the DB #5911

Closed
hjoliver opened this issue Jan 9, 2024 · 1 comment · Fixed by #5923
Closed

Don't record satisfied clock triggers in the DB #5911

hjoliver opened this issue Jan 9, 2024 · 1 comment · Fixed by #5923
Assignees
Labels
efficiency For notable efficiency improvements small
Milestone

Comments

@hjoliver
Copy link
Member

hjoliver commented Jan 9, 2024

Currently all satisfied xtriggers get stored in the DB xtriggers table. This includes clock triggers, and "retry delay" triggers (which are implemented via clock triggers).

These really don't need to be stored in the DB

  • clock triggers will likely be the main cause of xtrigger table bloat
  • calling a clock trigger again unnecessarily, e.g. after restart, is quick (i.e. it doesn't matter) - a synchronous wall-time check, not an asynchronous sub-process call like for other xtriggers
@hjoliver hjoliver added small efficiency For notable efficiency improvements labels Jan 9, 2024
@hjoliver hjoliver added this to the 8.2.x milestone Jan 9, 2024
@hjoliver hjoliver mentioned this issue Jan 9, 2024
8 tasks
@wxtim wxtim self-assigned this Jan 9, 2024
@wxtim
Copy link
Member

wxtim commented Jan 9, 2024

I think I've done this, and I'm just writing tests for it, but I'll be refraining from pushing a branch util #5908 is in on master.

wxtim added a commit to wxtim/cylc that referenced this issue Jan 15, 2024
wxtim added a commit to wxtim/cylc that referenced this issue Jan 15, 2024
@wxtim wxtim linked a pull request Jan 16, 2024 that will close this issue
7 tasks
@oliver-sanders oliver-sanders modified the milestones: 8.2.x, cylc-8.2.5 Jan 24, 2024
wxtim added a commit to wxtim/cylc that referenced this issue Jan 26, 2024
@wxtim wxtim closed this as completed in 57fe4ae Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
efficiency For notable efficiency improvements small
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants