From 85449a48c931986cdbffbbc037a2542cdc4be087 Mon Sep 17 00:00:00 2001 From: Tim Pillinger <26465611+wxtim@users.noreply.github.com> Date: Mon, 30 Oct 2023 11:19:36 +0000 Subject: [PATCH] Response to review Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com> --- changes.d/5794.break.md | 5 +---- cylc/flow/scripts/report_timings.py | 9 ++++----- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/changes.d/5794.break.md b/changes.d/5794.break.md index d94865eda4f..53c5315b013 100644 --- a/changes.d/5794.break.md +++ b/changes.d/5794.break.md @@ -1,4 +1 @@ -Remove `cylc report-timings` from automatic installation with -`pip install cylc-flow[all]`. If you now wish to -install it use `pip install cylc-flow[report-timings]`. - Cylc Report timings will no longer work at Python 3.12. \ No newline at end of file +Remove `cylc report-timings` from automatic installation with `pip install cylc-flow[all]`. If you now wish to install it use `pip install cylc-flow[report-timings]`. `cylc report-timings` is incompatible with Python 3.12. \ No newline at end of file diff --git a/cylc/flow/scripts/report_timings.py b/cylc/flow/scripts/report_timings.py index fa57577c194..e024f231b2a 100755 --- a/cylc/flow/scripts/report_timings.py +++ b/cylc/flow/scripts/report_timings.py @@ -54,6 +54,8 @@ import sys from typing import TYPE_CHECKING + +from cylc.flow import LOG from cylc.flow.exceptions import CylcError from cylc.flow.id_cli import parse_id from cylc.flow.option_parsers import ( @@ -123,6 +125,8 @@ def main(parser: COP, options: 'Values', workflow_id: str) -> None: constraint='workflows', ) + LOG.warning('Cylc report-timings is will be retired soon.') + output_options = [ options.show_raw, options.show_summary, options.html_summary ] @@ -243,11 +247,6 @@ def write_category(self, buf, category, df_reshape, df_describe): pass def _check_imports(self): - if sys.version_info > (3, 11): - raise CylcError( - 'Cylc Report Timings is deprecated: It is incompatible' - ' with Python > 3.11' - ) try: import pandas except ImportError: