From d8330f91f2d0e6b07c3acd34cc8fd155950fc734 Mon Sep 17 00:00:00 2001 From: Diquan-BOM <165976689+Diquan-BOM@users.noreply.github.com> Date: Thu, 4 Apr 2024 12:54:11 +1000 Subject: [PATCH 1/3] Update xtrigger_mgr.py documentation add s after string templates in documentation --- cylc/flow/xtrigger_mgr.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cylc/flow/xtrigger_mgr.py b/cylc/flow/xtrigger_mgr.py index 243ea1cb20f..f6595b400a3 100644 --- a/cylc/flow/xtrigger_mgr.py +++ b/cylc/flow/xtrigger_mgr.py @@ -60,7 +60,7 @@ class TemplateVariables(Enum): [scheduling] initial cycle point = now [[xtriggers]] - my_xtrigger = my_xtrigger_fcn('%(workflow)', '%(point)') + my_xtrigger = my_xtrigger_fcn('%(workflow)s', '%(point)s') For an explanation of the substitution syntax, see `String Formatting Operations in the Python documentation From 7c1816ff27ab2546039591603e64e377298e2497 Mon Sep 17 00:00:00 2001 From: Diquan-BOM <165976689+Diquan-BOM@users.noreply.github.com> Date: Thu, 4 Apr 2024 14:50:56 +1000 Subject: [PATCH 2/3] Update CONTRIBUTING.md --- CONTRIBUTING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a1bf42e6215..75d6bbb86c9 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -93,6 +93,7 @@ requests_). - (Andrew Huang) - Cheng Da - Mark Dawson + - Diquan Jabbour (All contributors are identifiable with email addresses in the git version From ccec8807e682b42fe71b95d823501590c8aad882 Mon Sep 17 00:00:00 2001 From: Oliver Sanders Date: Thu, 4 Apr 2024 11:45:08 +0100 Subject: [PATCH 3/3] add mailmap entry --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 66f61c34ddb..17c44ef97b1 100644 --- a/.mailmap +++ b/.mailmap @@ -54,3 +54,4 @@ Tomek Trzeciak Tomek Trzeciak TomekTrzeciak github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> github-actions[bot] GitHub Action +Diquan Jabbour <165976689+Diquan-BOM@users.noreply.github.com>