-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigating between sections doesn't remember map position #24
Comments
It's a side-effect of the architecture - /journey is a separate page from / - so it's reloading the page from scratch. Not sure how we can get round this. Ideas:
|
Are you sure this isn't just a cookie setting in Google Maps? |
Pretty sure, alas. We would implement it in cookies, but it would be by hand, with an event listener. |
Feedback: "If I switch apps of safari windows, and then come back to cyclestreets mobile, it resets the map to the 'default' location each time, rather than leaving it as I had it. I was trying to use the map to copy some street names into another document, and finding it frustrating." Is this any use: ? |
Yes, if users are giving you this feedback, it probably is worth improving. Thanks for the link - yes, that is the method we'd use. As the 'advantages and disadvantages' list says, it needs cookies and extra javascript, but perhaps it is worth doing. |
Have checked a basic fix in, but it's not ideal, because when you return to the page you will get another 'looking for your location' message. Not easy to get round this without some tricky refactoring. Will leave this open as a long-term enhancement, as it would be much better to move the /journey and /photomap pages into index, then the problem wouldn't arise in the first place (and the code would probably be neater). It's quite a big change though. |
It seems to be working fine. By 'looking for your location' message, I don't get that. I only get 'Using your most recent location' which just feels unnecessary. Not a massive problem though. |
The feedback above was from me. Just to say your fix deals with this adequately, thanks very much. |
Testing the site while developing some new feature I'm regularly getting the 'looking for your location' message. This is on a device that doesn't know it's location - and it slows down my testing and feels awkward. Ideally I'd like the site to remember that it failed to get a location once and not try again until I prod it to do so, or if geolocation becomes available. |
The text was updated successfully, but these errors were encountered: