Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for http://www.cyclestreets.net/location/ URLs #91

Open
jezhiggins opened this issue May 24, 2014 · 5 comments
Open

Add support for http://www.cyclestreets.net/location/ URLs #91

jezhiggins opened this issue May 24, 2014 · 5 comments

Comments

@jezhiggins
Copy link
Member

No description provided.

@oliverlockwood
Copy link
Member

@jezhiggins I note that in https://github.com/cyclestreets/android/blob/master/libraries/cyclestreets-fragments/src/main/java/net/cyclestreets/MainSupport.java#L51-L57 we have support for cycle.st and m.cyclestreets.net URLs.

I appreciate this issue is 4 years old; but can you give any specifics of what support you had in mind for this?

@mvl22
Copy link
Member

mvl22 commented Jul 18, 2018

If someone has the app installed, and they follow a link (e.g. on Twitter) to e.g.
https://www.cyclestreets.net/location/80/
this should open the app at that photo location, not the browser.

Same applies to /journey/.../ IDs, etc.

@jezhiggins
Copy link
Member Author

m.cyclestreets.net are the URLs used by the mobile version of the site, and cycle.st are the shortened versions that appear right at the bottom of the page when you planned a journey. As they were both cyclestreets URLs it seemed reasonable (and safe) to register to open those up with in the app.

It's straightforward enough to extended through the cyclestreets URL space.

We could also, and this is potentially a little more controversial, register to open Google Maps location URLs - so for example if someone clicks a location on a calendar entry it could open in the app - or,
even more controversially, Google Maps routing URLs. Well, I say controversial, it was at the time, but less so now. CityMapper, OS Maps, etc, all offer to open location URLs. I haven't checked, but it may well be officially supported behaviour these days.

@oliverlockwood
Copy link
Member

We now do CycleStreets location URLs - see merged PR #319. Leaving this issue open to track the possibility of doing geo location URLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants