Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local setup: Allow-Access-Control-Origin is set to '*' #72

Open
mszulik opened this issue Aug 6, 2024 · 0 comments
Open

Local setup: Allow-Access-Control-Origin is set to '*' #72

mszulik opened this issue Aug 6, 2024 · 0 comments

Comments

@mszulik
Copy link
Contributor

mszulik commented Aug 6, 2024

This means all websites can embed videos. We could provide a way to configure this with NGINX maps.

Our image has two directories for NGINX configuration files which will be automatic loaded.

For global configuration options the directory /opt/docker/etc/nginx/conf.d can be used. For vhost configuration options the directory /opt/docker/etc/nginx/vhost.common.conf can be used. We'll have to check where to include the map. The variable provided by the map can then be used in the docker/location-root.conf file instead of the asterisk.

With the map, we could map the incoming Host Header to values, which can then be used as value for the Allow-Access-Control-Origin header. For the default, i.e. the Host header could not be mapped, we can just leave it empty and it should be denied (has to be tested).

@mszulik mszulik changed the title Local setup: Allow-Access-Control-Origin is set to Local setup: Allow-Access-Control-Origin is set to '*' Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant