Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context View: Do not allow context to be dragged into self #2718

Open
raineorshine opened this issue Dec 21, 2024 · 0 comments
Open

Context View: Do not allow context to be dragged into self #2718

raineorshine opened this issue Dec 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@raineorshine
Copy link
Contributor

raineorshine commented Dec 21, 2024

Steps to Reproduce

Case 1

- a
  - m
-f b
  - m
  1. Activate context view on a/m.
  2. Drag a/m~/a after a (as a sibling).

Case 2

Steps to Reproduce

- a
  - b
    - m
- c
  - m
  1. Activate context view on a/b/m.
  2. Drag a/b/m~/b after a/b/m~ (as a sibling).

Current Behavior

Maximum call stack exceeded.

Expected Behavior

First, moveThought should detect a potential cycle and bail if one is detected. Let's add a reducer test for this.

Second, the drop target should be disallowed and the thought should not be allowed to drop within itself.

@raineorshine raineorshine added the bug Something isn't working label Dec 21, 2024
@raineorshine raineorshine added this to the 📖 Context View I milestone Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant