Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importText: Do not merge duplicate descendants #2712

Open
raineorshine opened this issue Dec 20, 2024 · 0 comments
Open

importText: Do not merge duplicate descendants #2712

raineorshine opened this issue Dec 20, 2024 · 0 comments
Labels
hold Pause development performance Improve performance refactor Refactor without changing behavior

Comments

@raineorshine
Copy link
Contributor

raineorshine commented Dec 20, 2024

Steps to Reproduce

- a
  - b
- x
- [empty]

Paste the following into the empty thought:

- a
  - b
    - c
- y

Current Behavior

Merging duplicate descendants requires all descendants at the import destination to be fetched, which makes importing large amounts of thoughts slow.

- a
  - b
    - c
- x
- y

Expected Behavior

Remove the logic that fetches descendants and merges duplicate descendants.

- a
  - b
- a
  - b
    - c
- x
- y
@raineorshine raineorshine added refactor Refactor without changing behavior performance Improve performance hold Pause development labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold Pause development performance Improve performance refactor Refactor without changing behavior
Projects
None yet
Development

No branches or pull requests

1 participant