Remove error in src/commands/toggleSort.ts

[trevinhofmann]

This error can now be removed:

em/src/commands/toggleSort.ts

Lines 52 to 69 in 675cb90

	// Show an error if the ranks do not match the sort condition.
	// This is only needed for migrating to permasort, and can be removed after the migration is complete.
	error: state => {
	if (!state.cursor || isRoot(state.cursor)) return null
	const simplePath = simplifyPath(state, state.cursor)
	const id = head(simplePath)
	const sortPreference = getSortPreference(state, id)
	if (sortPreference.type === 'None') return null
	const childrenSorted = getAllChildrenSorted(state, id)
	const childrenRanked = getChildrenRanked(state, id)
	return childrenSorted.length === childrenRanked.length &&
	!childrenRanked.every((childRanked, i) => childRanked.id === childrenSorted[i].id)
	? 'Ranks do not match sort condition'
	: null
	},
	}

The question was originally raised here, and the error was confirmed to be ready for removal in a separate PR here.

[trevinhofmann]

I've found a case which triggers this condition. I will add details shortly.

[raineorshine]

Good catch! I will create a separate issue for the sort error (#2685).

The error function actually used the wrong path, which made it more confusing. Fixed in c277ca7.

[raineorshine]

Still finding sorting errors, so keeping it in for now.