Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded tmp path #23

Open
trasher opened this issue Mar 1, 2017 · 1 comment
Open

Hardcoded tmp path #23

trasher opened this issue Mar 1, 2017 · 1 comment

Comments

@trasher
Copy link
Contributor

trasher commented Mar 1, 2017

Hello,

There is a path that is hardcoded here:
https://github.com/cybermonde/odtphp/blob/master/src/Zip/PclZipProxy.php#L24

This is a problem since this implies the web app should have write access on some directories I do not want it to write to.
Since there is a constant defined for PclZip; I've used it on my side; see TECLIB@6c2f07d.

Let me know if that should be OK for you, I'll open a PR.

Thank you!

@cybermonde
Copy link
Owner

Hello, thank you to contribute, PR to avoid this tmp directory is a good idea !

@trasher trasher mentioned this issue Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants