Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to export if some assets are missing #22

Open
bobpaul opened this issue Oct 28, 2020 · 3 comments
Open

Not possible to export if some assets are missing #22

bobpaul opened this issue Oct 28, 2020 · 3 comments

Comments

@bobpaul
Copy link
Contributor

bobpaul commented Oct 28, 2020

It's currently not possible to export if some assets are missing. Games are often still playable with a few missing assets (esp if the missing asset is something like an instruction manual PDF).

I propose that this gets added as behavior to the "-f, --force" option.

It'd be nice if the export was somehow marked as incomplete, but it's just a zip file with .pak as the file extension. Any thoughts on this? We could include a list of missing assets as a text file in the PAK, or put the word incomplete in the default file name or something.

@bobpaul
Copy link
Contributor Author

bobpaul commented Nov 8, 2020

Normal PKZip comment text is something like {"Ver": 1, "Id": "779344331", "Type": "workshop"} Perhaps add something to this? A missing file count?

@cwoac
Copy link
Owner

cwoac commented Dec 7, 2020

It's probably a good idea to add; for the purposes of #27, I've labelled partials as .part.pak rather than .pak. Adding some form of indication as to what is missing is worth doing.
I'm uncertain on what amount of space we have in a comment, so perhaps a missing.txt might be more appropriate?

@bobpaul
Copy link
Contributor Author

bobpaul commented Dec 7, 2020

Hmm, good call. Looks like zips use 2 bytes for comment length, so I think max is 65535bytes. And putting that information in a separate file is more visible to someone who might open the file and try to extract things manually.

BUT Thinking about this a bit more, how useful is a list of missing URLs really? All of the URLs are already in the json file, afterall. I could see us generating this file but then never using it, and if that's what we expect then it's probably not worth generating the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants