Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mbfuncdisc.c line 54 Is this string correct? #21

Open
loki-amorf opened this issue Oct 23, 2020 · 1 comment
Open

mbfuncdisc.c line 54 Is this string correct? #21

loki-amorf opened this issue Oct 23, 2020 · 1 comment

Comments

@loki-amorf
Copy link

freemodbus/modbus/functions/mbfuncdisc.c

Line 54 in f167010

#if MB_FUNC_READ_COILS_ENABLED > 0

Why do we check if read coils were enabled?
Why don't we check if read discrete inputs were enabled?
I gues it should be something like #if MB_FUNC_READ_DISCRETE_INPUTS_ENABLED > 0
@CyrilJiang
Copy link

Yes，I think so.

mcurry-va pushed a commit to VolutionGroup/freemodbus that referenced this issue May 12, 2023
As per cwalter-at#21
8392dbc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@loki-amorf @CyrilJiang