Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any numbers for new models (open SP, ALIKED, SIFT)? #21

Open
ducha-aiki opened this issue Oct 18, 2023 · 3 comments
Open

Any numbers for new models (open SP, ALIKED, SIFT)? #21

ducha-aiki opened this issue Oct 18, 2023 · 3 comments

Comments

@ducha-aiki
Copy link

Hi,

I'd like to add some of this models to kornia if they are worth it.
Given that you have trained them, I guess you have some numbers?
If not, that's OK, just wanted to check.

This was referenced Oct 18, 2023
@sarlinpe
Copy link
Member

sarlinpe commented Oct 19, 2023

Hey @ducha-aiki,
We've now released the LightGlue models trained for ALIKED & SIFT: cvg/LightGlue@29f3e44 These models are frankly very good - we've added results on MegaDepth and will add results on other datasets later (some ScanNet results in PR #25, others likely after the CVPR deadline). As you can see, ALIKED+LightGlue is better than SuperPoint+SuperGlue and pretty close to SuperPoint+LightGlue. For SIFT we need to double the number of keypoints to reach this accuracy (because the detector is much less repeatable).

For now we're not releasing the model trained for SuperPoint-Open because it still needs some more tuning.

While we're at it: it would be really great to have a proper implementation of DoG in kornia, ideally at the level of performance of vlfeat/GPUSIFT. The current implementation is really terrible (I know this was in your TODOs 2 years ago).

@ducha-aiki
Copy link
Author

@sarlinpe thank you! I am surprised at ALIKED results tbh.

Regarding DoG in kornia - to be honest, while I see some value in it, and would like to finally fix that, I don't think it is going to be fast enough to compete with GPU-SIFT either alone or from colmap.
And then, don't see much point there, given enormous memory footprint of the proper Gaussian scale space. Do you see any other arguments for it besides just completeness?

@sarlinpe
Copy link
Member

  • kornia is easier to install than pycolmap (GPU-SIFT requires building from source, we don't yet have the bandwidth to ship cuda-enabled wheels)
  • when considering batching, a torch-SIFT could be faster than GPU-SIFT (which would make the training of LightGlue faster or at least more efficient)

Though I don't encourage anyone to use SIFT, except for data with strong in-plane rotations (where we don't have an optimal solution, yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants