Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renderer.vexflowNotes() build tuplets incorrectly that begin with division #221

Open
vanderstel opened this issue Mar 30, 2023 · 1 comment

Comments

@vanderstel
Copy link
Member

Renderer.vexflowNotes() calculates the length of a tuplet as the Tuplet.totalTupletLength() of the first note in the tuplet. This is a problem when the tuplet starts with a division of the note value, such as when an 8th triplet begins with 16th notes:

Screen Shot 2023-03-30 at 1 12 57 PM

@mscuthbert
Copy link
Member

yeah, this is a problem with all triplet generating software (for Finale, I basically have a muscle memory to create a [8844] tuplet by writing 4-8-8-left-left-delete(4)-right-right-4-4).

What absolutely needs to happen is to rewrite tinyNotation.TinyNotation to use a translation of the m21p Converter class, and then be able to make Converter subclasses like m21p allows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants