Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming convention lint warnings #2024

Closed
pokey opened this issue Nov 12, 2023 · 3 comments · Fixed by #2025
Closed

Fix naming convention lint warnings #2024

pokey opened this issue Nov 12, 2023 · 3 comments · Fixed by #2025
Labels
code quality Improvements to code quality

Comments

@pokey
Copy link
Member

pokey commented Nov 12, 2023

When we bumped our @typescript-eslint version in #1989, we started getting many lint warnings like the following:

/home/runner/work/cursorless/cursorless/packages/cheatsheet-local/src/webpack.config.ts
  8:8  warning  Import name `HtmlWebpackInlineSourcePlugin` must match one of the following formats: camelCase  @typescript-eslint/naming-convention
  9:8  warning  Import name `HtmlWebpackPlugin` must match one of the following formats: camelCase              @typescript-eslint/naming-convention

See eg https://github.com/cursorless-dev/cursorless/actions/runs/6840283981/job/18599382888. I'm not sure why we would be getting these warnings, as the default config looks like it should allow PascalCase for imports 🤔

@pokey pokey added the code quality Improvements to code quality label Nov 12, 2023
@pokey
Copy link
Member Author

pokey commented Nov 12, 2023

cc/ @auscompgeek any ideas on this one?

@auscompgeek
Copy link
Member

Looks like we updated to 6.9.0 which doesn't include that default: typescript-eslint/typescript-eslint@7ad86ee

@pokey
Copy link
Member Author

pokey commented Nov 13, 2023

Ah right so sounds like another upgrade should do the trick then? Nice catch thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improvements to code quality
Projects
Development

Successfully merging a pull request may close this issue.

2 participants