-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix naming convention lint warnings #2024
Labels
code quality
Improvements to code quality
Comments
cc/ @auscompgeek any ideas on this one? |
Looks like we updated to 6.9.0 which doesn't include that default: typescript-eslint/typescript-eslint@7ad86ee |
Ah right so sounds like another upgrade should do the trick then? Nice catch thanks! |
pokey
added a commit
that referenced
this issue
Nov 13, 2023
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 13, 2023
- Fixes #2024 ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When we bumped our
@typescript-eslint
version in #1989, we started getting many lint warnings like the following:See eg https://github.com/cursorless-dev/cursorless/actions/runs/6840283981/job/18599382888. I'm not sure why we would be getting these warnings, as the default config looks like it should allow PascalCase for imports 🤔
The text was updated successfully, but these errors were encountered: