Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gutenberg support #13

Open
3 tasks done
r-a-y opened this issue Nov 15, 2018 · 0 comments
Open
3 tasks done

Add Gutenberg support #13

r-a-y opened this issue Nov 15, 2018 · 0 comments

Comments

@r-a-y
Copy link
Member

r-a-y commented Nov 15, 2018 •
edited
Loading

Gutenberg is going to be the default editor in WordPress as of v5.0.0.

Let's add support for it.

Edit - I'm going to bump minimum support for Gutenberg to v5.2.0 since some JS properties have been changed since WP v5.0.0.

GIF:

GIF of new Google Drive block

Todo:

  • Fix issues with Gutenberg v4.5.1 (Fixed in commit 54aad80)
  • Fix auto-parsing in block since WP 5.3.0 (might affect lower versions as well) (see commit eff28d4)
  • Fix cosmetic issues with WP 5.4.0 (see commit 668e572)
    (And a bunch of other fixes!)
r-a-y added a commit that referenced this issue Nov 20, 2018
@r-a-y
First pass at Gutenberg support.
dd7ae9f 
See #13.
@r-a-y r-a-y mentioned this issue Nov 20, 2018
Closed
r-a-y added a commit that referenced this issue Sep 10, 2019
@r-a-y
Remove paragraph tags for fallback "audio" message.
ce88af8 
When using the Shortcode block, the fallback paragraph is showing when
it shouldn't due to Gutenberg's use of wpautop() (I'm guessing).

See #13.
r-a-y added a commit that referenced this issue Apr 9, 2020
@r-a-y
Gutenberg: Fix notices.
bd36a71 
Fixes deprecated wp.editor references for WordPress 5.2.0 and unique
key React notices.

See #13.
r-a-y added a commit that referenced this issue Apr 9, 2020
@r-a-y
Gutenberg: Fix styling for WordPress 5.3.0+.
668e572 
Requires adding some CSS classes and enqueuing a new stylesheet to
deal with editor styles.

See #13.
r-a-y added a commit that referenced this issue Apr 9, 2020
@r-a-y
Gutenberg: Bump minimum compatibility to WordPress 5.2.0.
67ed6a3 
Some JS has changed in Gutenberg, so we're bumping the minimum version
compatibility to WP v5.2.0.

See #13.
r-a-y added a commit that referenced this issue Apr 9, 2020
@r-a-y
Gutenberg: Fix issues with validating width and height values as numb…
7bd2a3a 
…ers.

See #13.
r-a-y added a commit that referenced this issue Apr 9, 2020
@r-a-y
Gutenberg: Change URL field to use URL input field instead of text.
099b588 
Also fixes the 'aria-label' attribute field.

See #13.
r-a-y added a commit that referenced this issue Apr 9, 2020
@r-a-y
Gutenberg: Add a help link directly in our block.
c502b26 
To assist users into finding their link for a Google Drive item, a
help link is now added below the URL field.

The help link defaults to our Github wiki page, but developers can
change the link with the 'ray_gdoc_help_url' filter to point to
another page.

See #13.
r-a-y added a commit that referenced this issue Apr 9, 2020
@r-a-y
Gutenberg: Introduce internal helper JS function, validateLink().
f848bb2 
See #13.
r-a-y added a commit that referenced this issue Apr 9, 2020
@r-a-y
Gutenberg: Fix issues with auto-parsing URL after typing or pasting.
eff28d4 
Might need to tweak some of the JS a bit more.

See #13.
r-a-y added a commit that referenced this issue Apr 14, 2020
@r-a-y
Gutenberg: Fix rendering of 'audio' type.
1c24e37 
See #13.
r-a-y added a commit that referenced this issue Apr 14, 2020
@r-a-y
Gutenberg: If 'downloadlink' is true, make sure it is checked by defa…
0629656 
…ult.

See #13.
r-a-y added a commit that referenced this issue Apr 14, 2020
@r-a-y
Gutenberg: Ensure link is a minimum of 61 characters.
005634d 
See #13.
r-a-y added a commit that referenced this issue Apr 14, 2020
@r-a-y
Gutenberg: When clicking on the Reset button, ensure all properties a…
d0246cf 
…re wiped out.

See #13.
r-a-y added a commit that referenced this issue Apr 14, 2020
@r-a-y
Gutenberg: Initialize and remove timer during mounting and unmounting.
4dc9f92 
The timer is used for checking user inputs.

See #13.
r-a-y added a commit that referenced this issue Apr 14, 2020
@r-a-y
Gutenberg: Set a default width and height.
a7e732a 
See #13.
r-a-y added a commit that referenced this issue Apr 14, 2020
@r-a-y
Gutenberg: Don't set default width and height for presentations.
59d574e 
Presentations will use the 'size' attribute by default.

See #13.
r-a-y added a commit that referenced this issue Apr 14, 2020
@r-a-y
Gutenberg: Increase URL input change timeout to 2 seconds.
189a179 
This is for people that are typing out the link and might be slow
typers.

See #13.
r-a-y added a commit that referenced this issue Apr 14, 2020
@r-a-y
Gutenberg: Remove paragraph spacing in our block.
4538160 
See #13.
r-a-y added a commit that referenced this issue Apr 14, 2020
@r-a-y
Gutenberg: Ensure 'seamless' doc attribute has a default value.
86bb669 
See #13.
r-a-y added a commit that referenced this issue Apr 14, 2020
@r-a-y
Gutenberg: Set taller default height for 'form' type.
771124b 
See #13.
r-a-y added a commit that referenced this issue Apr 14, 2020
@r-a-y
Gutenberg: Download option should not show up for forms.
dc8336b 
See #13.
r-a-y added a commit that referenced this issue Nov 17, 2020
@r-a-y
Gutenberg: Update styles for WordPress 5.5.0.
636cdda 
See #13.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@r-a-y