Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

any way to account for domain mapping? #2

Open
anointed opened this issue Oct 6, 2012 · 16 comments
Open

any way to account for domain mapping? #2

anointed opened this issue Oct 6, 2012 · 16 comments

Comments

@anointed
Copy link

anointed commented Oct 6, 2012

I'd estimate that 50% of the blogs on my network use the domain mapping plugin.

When I use the cac widget on the primary site and choose to show articles from any of the other sites, the links to 'read more' the title etc, are not taking into account the fact that the site is using domain mapping.

The info is readily available in the db. Feature request would be to have the widget utilize the custom domain name if its available.

Thanks

@humanshell
Copy link
Collaborator

I'm hoping to get a 1.0.1 release out this week. I'm not familiar with the domain mapping plugin but I will investigate and do my best to get this feature request into that release.

@anointed
Copy link
Author

anointed commented Oct 7, 2012

@humanshell
Copy link
Collaborator

Thank you, this will help a lot.

@anointed
Copy link
Author

anointed commented Oct 7, 2012

sure thing if there is anything else I can help with, let me know. I have a few multisite installs to test everything on.

*It would be especially cool to see the widgets extended someday to allow for displaying more than just 1 group/blog/post/member/etc

@humanshell
Copy link
Collaborator

Do you mean additional content besides group/blog/post/member or more than one in a single widget?

@anointed
Copy link
Author

anointed commented Oct 7, 2012

each widget displaying more than 1 article/group/blog/member/

I would put 1 widget on my page to display my top 'x' members, or top 'x' groups etc..

right now it seems that for instance when on groups widget, I can only display 1 featured group, not 5

example: http://awesomescreenshot.com/017icjiec

example 2: http://awesomescreenshot.com/0c0icjmf1

@humanshell
Copy link
Collaborator

I like this idea. Will work on it for future 1.0.x releases.

@anointed
Copy link
Author

anointed commented Oct 7, 2012

AWESOME!
I'll do all i can to help when they're released as I get email updates on this topic :)

@humanshell
Copy link
Collaborator

I'm doing a little local testing right now. Could you explain a little more about what is or is not working on your installs?

I've got a fresh checkout of WP and BP trunk and domain mapping installed and enabled as their docs describe. I've setup a local subdomain site and enabled domain mapping on that site. When I add this new site to a Featured Content widget the Blog name and Read More links are pointing to the subdomain (testing.wp-net.dev). I assume this is what you mean when you say my plugin isn't correctly taking into account the domain mapping?

The domain map I setup on this testing site points to nettesting.dev. When I click a link in the Featured Content widget WP tries to render nettesting.dev but my local env isn't properly configured to resolve that address. Technically, isn't this working the way it's supposed to? Or do you want the Featured Content plugin to use the URL setup in the domain mapping plugin? For example should the links in the Featured Content widget be pointing to nettesting.dev instead of testing.wp-net.dev?

Let me know if this example doesn't make any sense! :-)

@anointed
Copy link
Author

anointed commented Oct 8, 2012

Sure thing: http://bit.ly/OgKVq4

On the right sidebar I have put a bunch of your CAC widgets to show you what I mean.

Featured Post, and Featured Site are CAC widgets. They are pointing to jerry.anointed.net. That sub-domain is actually mapped to jerrygaffney.net

What I was saying is that all the links should NOT go to jerry.anointed.net but should point to jerrygaffney.net, but for that to work your plugin would need to check to see if the sub-domain site is using the domain mapping plugin and if so, grab the mapped domain to use for links.

http://awesomescreenshot.com/02eif1ma6

@anointed
Copy link
Author

anointed commented Oct 8, 2012

To answer your question.. yes links should point to nettesting.dev not testing.wp-net.dev

Real Reason:
Most of my domain mapped sites are real clients who actually don't even know they're gonna be on a subdomain install of wordpress. Not to mention it causes probs with duplicate content with google having 2 exact copies of articles on different domains.

@humanshell
Copy link
Collaborator

OK, got it. I'm gonna test out a few different ways to integrate domain mapping checks into the plugin when it assembles all that info for display. I'll let you know when there's something pushed up to master so you can check it out and verify.

@humanshell
Copy link
Collaborator

That google issue would be a real problem, if I remember correctly they've got some pretty serious penalties for duplicate content.

@anointed
Copy link
Author

anointed commented Oct 8, 2012

awesome. I'll help test anything you find.

btw, not sure if you have seen this before, but WOW is it worth looking at: http://bit.ly/GGpitL

Might have some other cool ideas for your plugin. They only 'semi' related concepts, and I only found it last night, but there are some great ideas in there.

YES, HUGE penalty for duplicate content, basically it can completely destroy your page rank very quickly. Most people who run domain mapping don't realize how serious the problem is. You have to be VERY careful not to install any plugin, theme, widget etc, that would cause duplicate content links.

@humanshell
Copy link
Collaborator

No, I'd never seen NL Posts. But it is a good looking plugin!

@humanshell
Copy link
Collaborator

OK, it's taken a lot longer than I'd anticipated due to midterms but I think I've figured out how to make Featured Content integrate with Domain Mapping. I've added some code to the static helper class that checks for multisite and then adjusts both blog url and post permalinks. Before they were being pulled directly from the DB, bypassing Domain Mapping all together.

I'd like to ask you to help with testing now, if you're still interested. :-)

The updated code is in the 1.0.x branch, and you can see the exact additions here:

58523b6

Would you please clone the repo and test out locally to make sure I haven't missed any edge cases?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants