Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] replace hardcoded conda env, remove deprecated FindCUDA.cmake, added logic regarding libtorch download #29

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

debashishc
Copy link
Contributor

  • Native CUDA Support:

    • Removed the deprecated find_package(CUDA) in favor of native CMake CUDA support using enable_language(CUDA).
    • Set CMake policy CMP0146 to NEW to suppress warnings about FindCUDA.
    • Updated project() declaration to include CUDA as a language.
  • Dynamic Conda Environment Detection:

    • Replaced hardcoded Conda environment paths with dynamic detection using the CONDA_PREFIX environment variable.
    • If no Conda environment is detected, a warning is issued, and users are advised to set the environment manually.
  • Improved Handling of libtorch:

    • Replaced external wget calls with CMake’s file(DOWNLOAD ...) and execute_process commands for downloading and extracting libtorch.
    • Added logic to check if libtorch is already downloaded to avoid redundant operations or necessity to uncomment.
  • Refined Build Process:

    • Ensured that libtorch is properly added to CMAKE_PREFIX_PATH, allowing find_package(Torch REQUIRED) to work as expected.
    • CUDA support is now natively handled without relying on deprecated modules.

remove deprecated , added logic regarding libtorch download
@msaroufim msaroufim self-requested a review October 11, 2024 01:08
@msaroufim msaroufim merged commit 7a6fc7d into gpu-mode:main Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants