[refactor] replace hardcoded conda env, remove deprecated FindCUDA.cmake, added logic regarding libtorch download #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native CUDA Support:
find_package(CUDA)
in favor of native CMake CUDA support usingenable_language(CUDA)
.CMP0146
toNEW
to suppress warnings aboutFindCUDA
.project()
declaration to include CUDA as a language.Dynamic Conda Environment Detection:
CONDA_PREFIX
environment variable.Improved Handling of
libtorch
:wget
calls with CMake’sfile(DOWNLOAD ...)
andexecute_process
commands for downloading and extractinglibtorch
.libtorch
is already downloaded to avoid redundant operations or necessity to uncomment.Refined Build Process:
libtorch
is properly added toCMAKE_PREFIX_PATH
, allowingfind_package(Torch REQUIRED)
to work as expected.