Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use API Extractor for TypeScript modules #1664

Open
aslakhellesoy opened this issue Jul 17, 2021 · 1 comment
Open

Use API Extractor for TypeScript modules #1664

aslakhellesoy opened this issue Jul 17, 2021 · 1 comment
Labels
language: javascript 🔧 build Related to build / release process

Comments

@aslakhellesoy
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Exposing the right API from TypeScript modules is tricky as we've discussed in #1660 (review)

Describe the solution you'd like

Adopt API Extractor which solves this problem

Describe alternatives you've considered

Using a homegrown namespace as currently implemented in #1660, but that doesn't really solve the "we forgot to export this file" problem.

Additional context

This is also related to @mpkorstanje's recent soapbox talks about having stable public APIs.
@aslakhellesoy aslakhellesoy added language: javascript 🔧 build Related to build / release process labels Jul 17, 2021
@davidjgoss
Copy link
Contributor

davidjgoss commented Jul 19, 2021 •
edited
Loading

This will be great! I did try to add it a while ago and ran into some issues, but IIRC it was because of some peculiarities in the TypeScript code emitted by protobufjs, so hopefully smooth sailing this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
language: javascript 🔧 build Related to build / release process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aslakhellesoy @davidjgoss