Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InstantId #242

Closed
TingTingin opened this issue Jan 22, 2024 · 37 comments
Closed

InstantId #242

TingTingin opened this issue Jan 22, 2024 · 37 comments

Comments

@TingTingin
Copy link

looking into https://github.com/InstantID/InstantID it seems like its actually also uses insightface and ipadapter might be easy to integrate

@hben35096
Copy link

The effect is fantastic!!
Hopefully, it will work well with other nodes in Comfyui.

image
image
image

@cubiq
Copy link
Owner

cubiq commented Jan 22, 2024

OMG we are all gonna die!
image

@hben35096
Copy link

OMG we are all gonna die! !

This feature has been added??!!!

@xiaohu2015
Copy link

OMG we are all gonna die! image

Don't be so sad, haha, there will always be something better, and this is something you should be happy about.

@cubiq
Copy link
Owner

cubiq commented Jan 23, 2024

I'm just kidding, just wanted to show that I'm working on the instantid extension. It's so similar to IPAdapter that I could put everything together (but I will make an external plugin)

@xiaohu2015
Copy link

I'm just kidding, just wanted to show that I'm working on the instantid extension. It's so similar to IPAdapter that I could put everything together (but I will make an external plugin)

yes, IP-Adapter plus ControlNet, i would also like to combine InstantID with other ip adapters

@hben35096
Copy link

It's really exciting

@zsxkib
Copy link

zsxkib commented Jan 24, 2024

great work!

@johndpope
Copy link

johndpope commented Jan 25, 2024

@ZHO-ZHO-ZHO crafted comfyui-instantid - I'm looking to use ip adapter with it.

this is the repo -
https://github.com/ZHO-ZHO-ZHO/ComfyUI-InstantID/

I want to plug in an image ref instead of the text prompt as described here
instantX-research/InstantID#56

anyone able to assist?

UPDATE - looks like there's some updated workflows
Screenshot from 2024-01-25 13-46-02

@hben35096
Copy link

crafted comfyui-instantid - 我想用 ip 适配器来使用它。

这是回购 - https://github.com/ZHO-ZHO-ZHO/ComfyUI-InstantID/

我想插入图像引用而不是文本提示,如此处所述 InstantID/InstantID#56

有人能帮忙吗?

更新 - 看起来有一些更新的工作流程 Screenshot from 2024-01-25 13-46-02

@ZHO-ZHO-ZHO crafted comfyui-instantid - I'm looking to use ip adapter with it.

this is the repo - https://github.com/ZHO-ZHO-ZHO/ComfyUI-InstantID/

I want to plug in an image ref instead of the text prompt as described here InstantID/InstantID#56

anyone able to assist?

As far as I know, ZHO's ComfyUI-InstantID can't even connect to the one that comes with Comfyui
KSampler, although its version can be opened in Comfyui, is difficult to use with other nodes in Comfyui.

@GXcells
Copy link

GXcells commented Jan 25, 2024

OMG we are all gonna die! image

There is also a LORA for InstandID to add in addition to the IP adapter?

@GXcells
Copy link

GXcells commented Jan 25, 2024

@ZHO-ZHO-ZHO crafted comfyui-instantid - I'm looking to use ip adapter with it.

this is the repo - https://github.com/ZHO-ZHO-ZHO/ComfyUI-InstantID/

I want to plug in an image ref instead of the text prompt as described here InstantID/InstantID#56

anyone able to assist?

UPDATE - looks like there's some updated workflows Screenshot from 2024-01-25 13-46-02

This repo is a bit complicated.
I will wait for Cubiq's own implementation that will be probably much cleaner and easy.

@jesenzhang
Copy link

@ZHO-ZHO-ZHO crafted comfyui-instantid - I'm looking to use ip adapter with it.
this is the repo - https://github.com/ZHO-ZHO-ZHO/ComfyUI-InstantID/
I want to plug in an image ref instead of the text prompt as described here InstantID/InstantID#56
anyone able to assist?
UPDATE - looks like there's some updated workflows Screenshot from 2024-01-25 13-46-02

This repo is a bit complicated. I will wait for Cubiq's own implementation that will be probably much cleaner and easy.

I'm waiting too.

@johndpope
Copy link

I ask @ZHO-ZHO-ZHO to switch his insightfaceloader over - ZHO-ZHO-ZHO/ComfyUI-InstantID#49 - please upvote.

@thibaudart
Copy link

OMG we are all gonna die! image

did you fix your last issue with the controlnet part?

@cubiq
Copy link
Owner

cubiq commented Jan 27, 2024

not completely I have issues with high/low CFG for some reason. I hadn't much time to work on it yet unfortunately.

@thibaudart
Copy link

thanks to start the implementation . maybe if you share someone can find a solution.
you did an important work with your extension. thank you so much.

@cubiq
Copy link
Owner

cubiq commented Jan 27, 2024

@thibaudart I have no problem at sharing my shitty code 😄 https://github.com/cubiq/ComfyUI_InstantID

that is the base code, but more work is needed, it's not the latest version that I have locally but it's a good starting point.

@hben35096
Copy link

Mikubill/sd-webui-controlnet#2589
ControlNet has added Instant ID and seems to fix some issues

@thibaudart
Copy link

@cubiq thanks for sharing!
@hben35096 it's for webui not comfy :(

@jesenzhang
Copy link

Any updates?

@spenc-r
Copy link

spenc-r commented Jan 31, 2024

Curious if attention masking would work with InstantID. Any resources anyone could point me to? Found this commit but hard for me to understand, as I am new to SD. I am interested in writing an implementation

@johndpope
Copy link

instantX-research/InstantID#89 this has some masking - spenc-r

@cubiq
Copy link
Owner

cubiq commented Jan 31, 2024

yes attention masking is possible

@qqqllppp
Copy link

qqqllppp commented Feb 2, 2024

ZHO^3 's instantID eats too much vram, im getting oom even on 12gb vram 😭 Im crossing my fingers hoping the implementation here would eat less vram 🙏🏼

@JorgeR81
Copy link

JorgeR81 commented Feb 2, 2024

ZHO^3 's instantID eats too much vram, im getting oom even on 12gb vram

I think this may be due to a bug in that implementation.
ZHO-ZHO-ZHO/ComfyUI-InstantID#66

( and apparently InstantID works well in A1111, with 6gb vram, in low vram mode )
ZHO-ZHO-ZHO/ComfyUI-InstantID#66 (comment)

@thibaudart
Copy link

thibaudart commented Feb 2, 2024 via email

@cubiq
Copy link
Owner

cubiq commented Feb 2, 2024

I just pushed a tiled node for IPAdapter and I'm also working on a clip-vision mask option (probably tomorrow), then I'll check the InstantID. I think I have it 90% sorted out already

@hortom
Copy link

hortom commented Feb 3, 2024

Maybe it could be useful: I added some amateur-ish VRAM optimisations to ZHO's node here: ZHO-ZHO-ZHO/ComfyUI-InstantID#87

@cubiq
Copy link
Owner

cubiq commented Feb 9, 2024

image

It is finally working!

I'll post the code tomorrow

@cubiq
Copy link
Owner

cubiq commented Feb 10, 2024

Okay the InstantID native code is live. I think it's still beta but seems to be working very well. Please read the README file for important information.

https://github.com/cubiq/ComfyUI_InstantID

instantid instantid

/cc @xiaohu2015

@cubiq cubiq closed this as completed Feb 10, 2024
@camoody1
Copy link

@cubiq Thank you! Quick question... In your Readme file, you mention watermarks being everywhere. Is this because of the turbo model you're using or from the InstantID model?

@cubiq
Copy link
Owner

cubiq commented Feb 10, 2024

it comes from the instantID model. it can be fixed easily by changing the resolution slightly

@hortom
Copy link

hortom commented Feb 10, 2024

As I see, it is suggested to use a preprocessor for the sample images for insight face. I use padding for the pose.

@edtjulien
Copy link

@cubiq Thanks so much for your work!

@cubiq
Copy link
Owner

cubiq commented Feb 10, 2024

As I see, it is suggested to use a preprocessor for the sample images for insight face. I use padding for the pose.

the preprocessor shouldn't be needed unless you have a very extreme closeup, even then I iteratively lower the detection resolution and this technique has a very high detection rate

@cubiq
Copy link
Owner

cubiq commented Feb 10, 2024

also supports multiple people

ComfyUI_temp_shjmq_00009_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests