-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InstantId #242
Comments
This feature has been added??!!! |
I'm just kidding, just wanted to show that I'm working on the instantid extension. It's so similar to IPAdapter that I could put everything together (but I will make an external plugin) |
yes, IP-Adapter plus ControlNet, i would also like to combine InstantID with other ip adapters |
It's really exciting |
great work! |
@ZHO-ZHO-ZHO crafted comfyui-instantid - I'm looking to use ip adapter with it. this is the repo - I want to plug in an image ref instead of the text prompt as described here anyone able to assist? |
As far as I know, ZHO's ComfyUI-InstantID can't even connect to the one that comes with Comfyui |
This repo is a bit complicated. |
I'm waiting too. |
I ask @ZHO-ZHO-ZHO to switch his insightfaceloader over - ZHO-ZHO-ZHO/ComfyUI-InstantID#49 - please upvote. |
not completely I have issues with high/low CFG for some reason. I hadn't much time to work on it yet unfortunately. |
thanks to start the implementation . maybe if you share someone can find a solution. |
@thibaudart I have no problem at sharing my shitty code 😄 https://github.com/cubiq/ComfyUI_InstantID that is the base code, but more work is needed, it's not the latest version that I have locally but it's a good starting point. |
Mikubill/sd-webui-controlnet#2589 |
@cubiq thanks for sharing! |
Any updates? |
Curious if attention masking would work with InstantID. Any resources anyone could point me to? Found this commit but hard for me to understand, as I am new to SD. I am interested in writing an implementation |
instantX-research/InstantID#89 this has some masking - spenc-r |
yes attention masking is possible |
ZHO^3 's instantID eats too much vram, im getting oom even on 12gb vram 😭 Im crossing my fingers hoping the implementation here would eat less vram 🙏🏼 |
I think this may be due to a bug in that implementation. ( and apparently InstantID works well in A1111, with 6gb vram, in low vram mode ) |
the biggest issue with Zho implementation is the fact we can’t use it in a
complex workflow :(
T
Le ven. 2 févr. 2024 à 19:22, JorgeR81 ***@***.***> a écrit :
… ZHO^3 's instantID eats too much vram, im getting oom even on 12gb vram
I think this may be due to a bug in that implementation.
ZHO-ZHO-ZHO/ComfyUI-InstantID#66
<ZHO-ZHO-ZHO/ComfyUI-InstantID#66>
( and apparently InstantID works well in A1111, with 6gb vram, in low vram
mode )
ZHO-ZHO-ZHO/ComfyUI-InstantID#66 (comment)
<ZHO-ZHO-ZHO/ComfyUI-InstantID#66 (comment)>
—
Reply to this email directly, view it on GitHub
<#242 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYWNXDDO47UKJHW7GN6AEMTYRUVHHAVCNFSM6AAAAABCFUX4H6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRUGQ2DQNBTGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I just pushed a tiled node for IPAdapter and I'm also working on a clip-vision mask option (probably tomorrow), then I'll check the InstantID. I think I have it 90% sorted out already |
Maybe it could be useful: I added some amateur-ish VRAM optimisations to ZHO's node here: ZHO-ZHO-ZHO/ComfyUI-InstantID#87 |
Okay the InstantID native code is live. I think it's still beta but seems to be working very well. Please read the README file for important information. https://github.com/cubiq/ComfyUI_InstantID /cc @xiaohu2015 |
@cubiq Thank you! Quick question... In your Readme file, you mention watermarks being everywhere. Is this because of the turbo model you're using or from the InstantID model? |
it comes from the instantID model. it can be fixed easily by changing the resolution slightly |
As I see, it is suggested to use a preprocessor for the sample images for insight face. I use padding for the pose. |
@cubiq Thanks so much for your work! |
the preprocessor shouldn't be needed unless you have a very extreme closeup, even then I iteratively lower the detection resolution and this technique has a very high detection rate |
looking into https://github.com/InstantID/InstantID it seems like its actually also uses insightface and ipadapter might be easy to integrate
The text was updated successfully, but these errors were encountered: