Skip to content
This repository has been archived by the owner on Oct 14, 2020. It is now read-only.

Update linter to check jsx files #312

Open
jfly opened this issue May 6, 2016 · 3 comments
Open

Update linter to check jsx files #312

jfly opened this issue May 6, 2016 · 3 comments
Assignees
@coder13

Comments

@jfly
Copy link
Member

jfly commented May 6, 2016

As we move to react, this is going to become more and more important.

http://www.sitepoint.com/comparison-javascript-linting-tools/ and https://github.com/STRML/JSXHint say we should be using ESLint.

IMO, this is important to do before we start heavy React development.
@jfly jfly self-assigned this May 6, 2016
@coder13
Copy link
Member

coder13 commented May 8, 2016

I agree on eslint as I hate having to keep turning it off. I can get this setup if you want.

@jfly
Copy link
Member Author

jfly commented May 8, 2016

If you've got the time to work on this, please assign this to yourself and go for it!

@coder13 coder13 assigned coder13 and unassigned jfly May 13, 2016
coder13 added a commit that referenced this issue May 13, 2016
@coder13
switched from jshint to eslint, fixed linting errors. Adresses #312
e27a821
@coder13
Copy link
Member

coder13 commented Aug 3, 2016

I think I fixed this issue during my big rewrite, I'll close this after I merge to master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@coder13 coder13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jfly @coder13