Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log In Change -- Get Rid of Toast #118

Closed
thisjustin123 opened this issue Mar 5, 2024 · 1 comment
Closed

Log In Change -- Get Rid of Toast #118

thisjustin123 opened this issue Mar 5, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@thisjustin123
Copy link
Contributor

Description:

Gregor, as a temporary implementation before design was finalized, implemented feedback for the login flow with toasts--LoginToast. We want to substitute this out for text on the button.

You should do the following, as Funmi specified:

  • The login button should say "Logging in..." for a bit as it does right now.
  • Whenever the Authenticating toast would show, change the button text to "Authenticating..." instead.
  • Whenever the Successful Login toast would show, change the button text to "Successful Login!" instead.
@thisjustin123 thisjustin123 added the enhancement New feature or request label Mar 5, 2024
@thisjustin123
Copy link
Contributor Author

Blocked until design comes up with a better solution.

@thisjustin123 thisjustin123 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants